From 743ab291c7841c566616f988715e55dc66d2c620 Mon Sep 17 00:00:00 2001 From: obligaron Date: Wed, 8 Jan 2025 19:07:21 +0100 Subject: [PATCH] Remove Specflow remains in links and comments (#382) * Remove Specflow remains * lower case reqnroll for app config --- .../DependencyInjectionPlugin.cs | 2 +- .../ScenarioDependenciesAttribute.cs | 2 +- .../UnitTestProvider/NUnit3TestGeneratorProvider.cs | 2 +- ...052.feature => ScenarioIsCorrectInParallelExecution.feature} | 2 +- ...052.feature => ScenarioIsCorrectInParallelExecution.feature} | 2 +- .../Factories/ConfigurationGenerator/AppConfigGenerator.cs | 2 +- .../Reqnroll.TestProjectGenerator/ProjectBuilder.cs | 1 - 7 files changed, 6 insertions(+), 7 deletions(-) rename Tests/Reqnroll.Specs/Features/RegressionTests/MsTest/{GH1052.feature => ScenarioIsCorrectInParallelExecution.feature} (98%) rename Tests/Reqnroll.Specs/Features/RegressionTests/NUnit/{GH1052.feature => ScenarioIsCorrectInParallelExecution.feature} (98%) diff --git a/Plugins/Reqnroll.Microsoft.Extensions.DependencyInjection.ReqnrollPlugin/DependencyInjectionPlugin.cs b/Plugins/Reqnroll.Microsoft.Extensions.DependencyInjection.ReqnrollPlugin/DependencyInjectionPlugin.cs index 79070dbdc..3abf2b102 100644 --- a/Plugins/Reqnroll.Microsoft.Extensions.DependencyInjection.ReqnrollPlugin/DependencyInjectionPlugin.cs +++ b/Plugins/Reqnroll.Microsoft.Extensions.DependencyInjection.ReqnrollPlugin/DependencyInjectionPlugin.cs @@ -133,7 +133,7 @@ private static void RegisterProxyBindings(IObjectContainer objectContainer, ISer // While they can (and should) use the method params for injection, we can support it. // Note that in Feature mode, one can't inject "ScenarioContext", this can only be done from method params. - // Bases on this: https://docs.specflow.org/projects/specflow/en/latest/Extend/Available-Containers-%26-Registrations.html + // Bases on this: https://docs.reqnroll.net/latest/extend/available-containers.html#global-container // Might need to add more... services.AddSingleton(objectContainer); diff --git a/Plugins/Reqnroll.Microsoft.Extensions.DependencyInjection.ReqnrollPlugin/ScenarioDependenciesAttribute.cs b/Plugins/Reqnroll.Microsoft.Extensions.DependencyInjection.ReqnrollPlugin/ScenarioDependenciesAttribute.cs index 156793148..3bcfbdb8e 100644 --- a/Plugins/Reqnroll.Microsoft.Extensions.DependencyInjection.ReqnrollPlugin/ScenarioDependenciesAttribute.cs +++ b/Plugins/Reqnroll.Microsoft.Extensions.DependencyInjection.ReqnrollPlugin/ScenarioDependenciesAttribute.cs @@ -18,7 +18,7 @@ public enum ScopeLevelType public class ScenarioDependenciesAttribute : Attribute { /// - /// Automatically register all SpecFlow bindings. + /// Automatically register all Reqnroll bindings. /// public bool AutoRegisterBindings { get; set; } = true; diff --git a/Reqnroll.Generator/UnitTestProvider/NUnit3TestGeneratorProvider.cs b/Reqnroll.Generator/UnitTestProvider/NUnit3TestGeneratorProvider.cs index 1d881bd4c..1b73a36c6 100644 --- a/Reqnroll.Generator/UnitTestProvider/NUnit3TestGeneratorProvider.cs +++ b/Reqnroll.Generator/UnitTestProvider/NUnit3TestGeneratorProvider.cs @@ -128,7 +128,7 @@ public void SetRow(TestClassGenerationContext generationContext, CodeMemberMetho var tagsArray = tags.ToArray(); - // addressing ReSharper bug: TestCase attribute with empty string[] param causes inconclusive result - https://github.com/SpecFlowOSS/SpecFlow/issues/116 + // addressing ReSharper bug: TestCase attribute with empty string[] param causes inconclusive result - https://youtrack.jetbrains.com/issue/RSRP-279138 bool hasExampleTags = tagsArray.Any(); var exampleTagExpressionList = tagsArray.Select(t => (CodeExpression)new CodePrimitiveExpression(t)); var exampleTagsExpression = hasExampleTags diff --git a/Tests/Reqnroll.Specs/Features/RegressionTests/MsTest/GH1052.feature b/Tests/Reqnroll.Specs/Features/RegressionTests/MsTest/ScenarioIsCorrectInParallelExecution.feature similarity index 98% rename from Tests/Reqnroll.Specs/Features/RegressionTests/MsTest/GH1052.feature rename to Tests/Reqnroll.Specs/Features/RegressionTests/MsTest/ScenarioIsCorrectInParallelExecution.feature index 5208f5815..1585100e3 100644 --- a/Tests/Reqnroll.Specs/Features/RegressionTests/MsTest/GH1052.feature +++ b/Tests/Reqnroll.Specs/Features/RegressionTests/MsTest/ScenarioIsCorrectInParallelExecution.feature @@ -1,7 +1,7 @@ @MSTest Feature: GH1052 -Wrong scenario context injected when running tests in parallel using NUnit (also specrun) - https://github.com/SpecFlowOSS/SpecFlow/issues/1052 +Wrong scenario context injected when running tests in parallel using NUnit Scenario: GH1052 diff --git a/Tests/Reqnroll.Specs/Features/RegressionTests/NUnit/GH1052.feature b/Tests/Reqnroll.Specs/Features/RegressionTests/NUnit/ScenarioIsCorrectInParallelExecution.feature similarity index 98% rename from Tests/Reqnroll.Specs/Features/RegressionTests/NUnit/GH1052.feature rename to Tests/Reqnroll.Specs/Features/RegressionTests/NUnit/ScenarioIsCorrectInParallelExecution.feature index 570dcc742..12792e6e3 100644 --- a/Tests/Reqnroll.Specs/Features/RegressionTests/NUnit/GH1052.feature +++ b/Tests/Reqnroll.Specs/Features/RegressionTests/NUnit/ScenarioIsCorrectInParallelExecution.feature @@ -3,7 +3,7 @@ @ignore Feature: GH1052 -Wrong scenario context injected when running tests in parallel using NUnit (also specrun) - https://github.com/reqnroll/Reqnroll/issues/1052 +Wrong scenario context injected when running tests in parallel using NUnit Scenario: GH1052 diff --git a/Tests/TestProjectGenerator/Reqnroll.TestProjectGenerator/Factories/ConfigurationGenerator/AppConfigGenerator.cs b/Tests/TestProjectGenerator/Reqnroll.TestProjectGenerator/Factories/ConfigurationGenerator/AppConfigGenerator.cs index 1e790efba..41c79ff75 100644 --- a/Tests/TestProjectGenerator/Reqnroll.TestProjectGenerator/Factories/ConfigurationGenerator/AppConfigGenerator.cs +++ b/Tests/TestProjectGenerator/Reqnroll.TestProjectGenerator/Factories/ConfigurationGenerator/AppConfigGenerator.cs @@ -61,7 +61,7 @@ private void WriteAppSettings(XmlWriter writer, Configuration configuration) private void WriteReqnroll(XmlWriter writer, Configuration configuration) { - writer.WriteStartElement("specFlow"); + writer.WriteStartElement("reqnroll"); if (configuration.BindingCulture != null) { diff --git a/Tests/TestProjectGenerator/Reqnroll.TestProjectGenerator/ProjectBuilder.cs b/Tests/TestProjectGenerator/Reqnroll.TestProjectGenerator/ProjectBuilder.cs index 92f275c78..1aca02017 100644 --- a/Tests/TestProjectGenerator/Reqnroll.TestProjectGenerator/ProjectBuilder.cs +++ b/Tests/TestProjectGenerator/Reqnroll.TestProjectGenerator/ProjectBuilder.cs @@ -231,7 +231,6 @@ private void EnsureProjectExists() _project.AddNuGetPackage("System.Runtime.CompilerServices.Unsafe", "6.0.0", new NuGetPackageAssembly("System.Runtime.CompilerServices.Unsafe, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a", "netstandard2.0\\System.Runtime.CompilerServices.Unsafe.dll")); } - // TODO: dei replace this hack with better logic when SpecFlow 3 can be strong name signed _project.AddNuGetPackage("Reqnroll", _currentVersionDriver.ReqnrollNuGetVersion, new NuGetPackageAssembly("Reqnroll", "net462\\Reqnroll.dll")); var generator = _bindingsGeneratorFactory.FromLanguage(_project.ProgrammingLanguage);