EPMRPP-84084 || Nested steps are not finished #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 12, 2023 22:20
The main problem was with the name collision. When nested step and parent has the same name. Property `id` was added to the `step` object as a temporary solution. We need to consider the possibility to rewrite `getCodeRef` util.
AmsterGet
reviewed
Jun 13, 2023
This was
linked to
issues
Jun 13, 2023
AmsterGet
approved these changes
Jun 13, 2023
AmsterGet
deleted the
bugfix/EPMRPP-84084-Launch-not-finished-when-includeTestSteps-and-retries-enabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main problem was with the name collision. When nested step and parent has the same name. Property
idwas added to thestepobject as a temporary solution.We need to consider the possibility to rewrite
getCodeRefutil.