feat: support for multi-stage builds #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nexdrew
changed the title
|
@marccampbell @emosbaugh Would love a review of this if you get a chance. 😎 |
|
@emosbaugh Thanks for the quick turnaround! Will wait to hear from #74 commenters before I proceed. |
nexdrew
force-pushed
the
multi-stage
branch
from
bde16c3 to
ed00203
Compare
|
@marccampbell @emosbaugh Thoughts on making this a major version bump? This question is the only reason I'm hesitant to merge and release this right now. |
nexdrew
force-pushed
the
multi-stage
branch
from
ed00203 to
9970cce
Compare
|
i see no reason to bump major version. no big refactor or anything and nothing incompatible or api changes |
Fair enough. I'll merge and release as a minor update then. Thanks! |
|
Published to npm as 1.4.0. |
Closed
svl7
pushed a commit
to svl7/dockerfilelint
that referenced
this pull request
Jun 22, 2020
interpret multiple FROM commands as multi-stage builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74.
The first commit adds tests for multi-stage builds (examples taken from Docker's documentation), which should fail.
The subsequent commits modify logic to get the tests to pass.
Instead of failing on each subsequent
FROMcommand, the logic now considers this as the beginning of a new build stage (as modeled by internal state during instructions processing).NOTE: This should probably be considered a BREAKING CHANGE, since Dockerfiles containing more than one
FROMcommand will no longer fail linting, which will be problematic if the (unspecified) target Docker version is less than 17.05. We could potentially get around this by introducing a way (e.g. CLI/config option or auto env detection) to specify/detect the Docker version, but this seems out-of-scope for this PR.Also note that this change does not add any new checks specific to multi-stage Dockerfiles, such as potentially checking that a stage has more than just a single
FROMcommand. Even so, the changes represented here could be considered a necessary first step, allowing stage-specific checks to be added later.