Expose flash keys ERROR and SUCCESS

[cies]

We had them defined locally, which it weird: they should come from the source.

[asolntsev]

Probably we should expose not these constants, but METHODS forbreading/adding these flash values?

[cies]

Probably we should expose not these constants, but METHODS forbreading/adding these flash values?

@asolntsev I disagree. there are standard methods for that, like .contains(...) and .get(...). Sure it would be nice to have, but since this is already how we've worked until now, i really believe simply exposing them is the right thing to do.

We currently have those same constants in our code, simply because they are not exposed and i dont like to use stings everywhere. :)

[asolntsev]

Probably we should expose not these constants, but METHODS forbreading/adding these flash values?

@asolntsev I disagree. there are standard methods for that, like .contains(...) and .get(...). Sure it would be nice to have, but since this is already how we've worked until now, i really believe simply exposing them is the right thing to do.

We currently have those same constants in our code, simply because they are not exposed and i dont like to use stings everywhere. :)

Can you share a code sample - how do you use those constants?

[cies]

@asolntsev suuure:

            flash.get(ERROR)?.let {
              div("hint hint--error") { +it }
            }
            flash.get(SUCCESS)?.let {
              div("hint hint--optional") { +it }
            }

div(if (flash.contains(SUCCESS) || flash.contains(ERROR)) "low-top-margin" else "") {
  // ...
}

[asolntsev]

Thank you. This is what I meant.
Instead of publishing constants ERROR and SUCCESS, it's better to publish methods like flash.getErrorMessage(), flash.getSuccessMessage(). Then it will be possible in the future to change the implementation details.

(though, it's not very important because internals of "flash" are already leaked anyway...)

[cies]

@asolntsev Updated it, have a look