Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session_request, session_update hooks for appkit [feature] #3457

Open
VGeorgiev1 opened this issue Dec 13, 2024 · 4 comments
Open

session_request, session_update hooks for appkit [feature] #3457

VGeorgiev1 opened this issue Dec 13, 2024 · 4 comments

Comments

@VGeorgiev1
Copy link

What problem does this new feature solve?

I have been creating a dApp with reown appKit and I really need to be able to execute some logic when a signing request for a transaction is initiated. I found that the WalletKit provides a hook for listening for the session_request event but I cant find a way of using it with appKit.
Its really confusing because when I reject a signing request i get the following error:
Object Error: emitting session_request:1733920443898539 without any listeners which makes me think that appkit already listens for those events but there are no exposed hooks for them.

Describe the solution you'd like

Easy way to register an event listenr for session_update session_request events etc.
Example: appKit.on('session_update', () => {})

Copy link

linear bot commented Dec 13, 2024

@rtomas
Copy link
Contributor

rtomas commented Dec 13, 2024

Thanks for your feature request. We will be analysing with the team.
Would you mind sharing what you are building ?

@VGeorgiev1
Copy link
Author

I would be able to share that, but I can assure you I have checked all of the web examples and there is no such feature or a close one to that in the AppKit.

@arein
Copy link
Contributor

arein commented Dec 17, 2024

We need to have a crisp explanation of your use case please do be able to cross-check whether we don't support that with the existing APIs and also in case we don't to be able to properly prioritize

I really need to be able to execute some logic when a signing request for a transaction is initiated

@VGeorgiev1 your app is initiating the signing request - aka usually user clicks a button in your app and then you trigger the signing request. So it's unclear why you need to hook into things lower level - please explain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants