Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pypi): fallback to simple lookup on 403 #26386

Closed
wants to merge 1 commit into from

Conversation

Kakadus
Copy link
Contributor

@Kakadus Kakadus commented Dec 20, 2023

Changes

This adds 403 to the simple index fallback check, so that pytorch index urls are correctly resolved by renovate.

Context

See #26383

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice
Copy link
Member

viceice commented Dec 20, 2023

🤔 this can cause a lot confusion when people try to get authentication to work with custom pypi registries.

@sorgfresser
Copy link

Right now the PyTorch dependency lookup fails with their private registry - while this might be an issue with torch's behaviour, renovate could fix this by defaulting to simple on 403s. I get that this could be confusing though.

Could this retry be achieved using hostRules in the renovate config defaulting to the old behaviour, i.e. no retry? This way we could fix the PyTorch-issue while still not confusing the setup of private registries.

@rarkins
Copy link
Collaborator

rarkins commented Jan 3, 2024

Can we just restrict it to the pytorch domain for now?

@rarkins
Copy link
Collaborator

rarkins commented Jan 3, 2024

This would be a harder but better long term solution: #26483

@Kakadus
Copy link
Contributor Author

Kakadus commented Jan 4, 2024

I've tried to implement this in #26505. Closing this in favor of it for now.

@Kakadus Kakadus closed this Jan 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants