Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use node v16 and test v18 #18584

Merged
merged 2 commits into from
Oct 26, 2022
Merged

ci: use node v16 and test v18 #18584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cadb41d
ci: use node v16 and test v18
viceice Oct 26, 2022
1b4d408
Merge branch 'main' into ci/node-v16-v18
viceice Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ concurrency:
env:
# Currently no way to detect automatically (#8153)
DEFAULT_BRANCH: main
NODE_VERSION: 14
NODE_VERSION: 16
DRY_RUN: true

jobs:
Expand All @@ -38,7 +38,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node-version: [14, 16]
node-version: [14, 16, 18]
JamieMagee marked this conversation as resolved.
Show resolved Hide resolved
# skip macOS and Windows test on pull requests without 'ci:fulltest' label
include: >-
${{ fromJSON((github.event_name != 'pull_request' || contains(github.event.pull_request.labels.*.name, 'ci:fulltest')) && '[{
Expand All @@ -50,7 +50,7 @@ jobs:
}]' || '[]') }}

env:
coverage: ${{ matrix.os == 'ubuntu-latest' && (matrix.node-version == 14 || matrix.node-version == 16) }}
coverage: ${{ matrix.os == 'ubuntu-latest' && (matrix.node-version == 16 || matrix.node-version == 18) }}
NODE_VERSION: ${{ matrix.node-version }}

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-npm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ on:
required: false

env:
NODE_VERSION: 14
NODE_VERSION: 16
GIT_SHA: ${{ github.event.client_payload.sha }}
NPM_VERSION: ${{ github.event.client_payload.version }}
NPM_TAG: ${{ github.event.client_payload.tag }}
Expand Down