fix(manager/github-actions): renovate propose to delete YAML inline comments

[Gabriel-Ladzaretti]

Changes

Modified extraction regex to be more precise.

Context

closes #12260

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[Gabriel-Ladzaretti]

https://github.com/ladzaretti/12260-2/pull/4/files

https://github.com/ladzaretti/12260-2/pull/1/files

[Gabriel-Ladzaretti]

https://github.com/Gabriel-Ladzaretti/renovate/blob/c28d0448c60c4ed437eadd58cdbfc6fd940f9153/lib/modules/manager/github-actions/extract.ts#L49

im using trim as the original solution to the problem @viceice mentioned (replaceString captures whitespace when there is no tag/renovate) used lookaheads. but it turns out RE2 does not supports that :{}

[astellingwerf]

Is there a test that proves the issue and the corresponding fix?

[Gabriel-Ladzaretti]

@astellingwerf

Is there a test that proves the issue and the corresponding fix?

#14757 (comment)

[viceice]

Also please add at least one comment sample to the fixtures files

[astellingwerf]

@astellingwerf

Is there a test that proves the issue and the corresponding fix?

#14757 (comment)

Well, those reside in another repo, so wouldn't be an integral part of the test suite for this code. I'd wanna see tests added (or updated) to the Renovate repo.

[Gabriel-Ladzaretti]

@astellingwerf

Is there a test that proves the issue and the corresponding fix?

#14757 (comment)

Well, those reside in another repo, so wouldn't be an integral part of the test suite for this code. I'd wanna see tests added (or updated) to the Renovate repo.

misunderstood 😅, anyhow ive added some

[viceice]

needs snapshot update

[renovate-release]

🎉 This PR is included in version 32.7.1 🎉

The release is available on:

• GitHub release
• 32.7.1

Your semantic-release bot 📦🚀