Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split mergeRenovateConfig to own module #9872

Merged
merged 4 commits into from
May 5, 2021

Conversation

56KBs
Copy link
Contributor

@56KBs 56KBs commented May 5, 2021

Changes:

Split mergeRenovateConfig and it's helper functions into another module in order to break a future circular dependency.

Context:

Requested to be raised separately in #9869.

This is just a migration of code, without any changes to the code other than the test snapshot

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Matthew Palmer added 2 commits May 5, 2021 15:26
Split mergeRenovateConfig and it's helper functions into another module in order to break a future circular dependency.
@56KBs 56KBs marked this pull request as ready for review May 5, 2021 15:29
@viceice viceice requested review from rarkins and JamieMagee May 5, 2021 16:20
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks like it's doing the same as before.

@rarkins rarkins merged commit 5cdedd5 into renovatebot:main May 5, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants