Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the packages inside a Dockerfile #3717

Closed
micheelengronne opened this issue May 16, 2019 · 11 comments
Closed

Update the packages inside a Dockerfile #3717

micheelengronne opened this issue May 16, 2019 · 11 comments
Labels
help wanted Help is needed or welcomed on this issue new package manager New package manager support status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)

Comments

@micheelengronne
Copy link

According to hadolint and the Docker documentation, we should pin packages in a Dockerfile

https://github.com/hadolint/hadolint/wiki/DL3008
https://github.com/hadolint/hadolint/wiki/DL3016
https://github.com/hadolint/hadolint/wiki/DL3018
https://github.com/hadolint/hadolint/wiki/DL3013

Renovate should be able to change the packages versions according to a repository or a list of repositories.

Currently, I wildcard to the major version of each package.

@rarkins
Copy link
Collaborator

rarkins commented May 16, 2019

Yes, but first we need to make sure we already have datasources for those, e.g. alpine packages.

Ones like npm would be easier as we already have great npm support.

@micheelengronne
Copy link
Author

Yes, but npm we can easily circumvent by importing an external package.json with its lock (yarn.lock or other).

That is not possible with system packages like apk and deb.

@rarkins
Copy link
Collaborator

rarkins commented May 16, 2019

Agreed. I was just mentioning that because "npm install" is one of the hadolint examples you gave. I would prefer to start on apk/deb too

@adam-moss
Copy link
Contributor

For alpine you can use http://dl-cdn.alpinelinux.org/alpine/ as the data source. Note alpine doesn't appear to keep old versions of products, only the latest is present in the repo.

@adam-moss
Copy link
Contributor

It would be nice if we could include yum support too :)

@micheelengronne
Copy link
Author

I think that the datasources should be configurable as users can configure other repositories than the default with more recent packages in them.

@rarkins rarkins added help wanted Help is needed or welcomed on this issue needs-requirements new package manager New package manager support labels May 16, 2019
@fullstackzach
Copy link
Contributor

I would be interested in this feature too, for alpine-linux package updates

@rarkins
Copy link
Collaborator

rarkins commented Jan 28, 2020

@fullstackzach can you give an example Dockerfile or line in particular?

@rarkins
Copy link
Collaborator

rarkins commented Mar 6, 2020

As a workaround it should be possible to add a custom rule using our new regex-based manager: https://docs.renovatebot.com/modules/manager/regex/
However potentially new datasources are needed first. So far this feature request is short on examples so not possible to be sure.

@rarkins rarkins added the type:feature Feature (new functionality) label Mar 6, 2020
@rarkins rarkins added the status:requirements Full requirements are not yet known, so implementation should not be started label Jan 12, 2021
@HonkingGoose
Copy link
Collaborator

Do we need other stuff before we can begin? New datasources maybe?

I also get the impression that we're waiting on examples given this comment from rarkins:

fullstackzach can you give an example Dockerfile or line in particular?

Maybe we should label this blocked if we're waiting for examples/input from other users?

Also I'm not sure what priority label to give this, so I'll let the Renovate team decide.

@rarkins
Copy link
Collaborator

rarkins commented Mar 8, 2021

I think we can close this. Reasoning:

@rarkins rarkins closed this as completed Mar 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Help is needed or welcomed on this issue new package manager New package manager support status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

6 participants