feat(maven): Remove unnecessary HTML page fetches #32662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zharinov
requested review from
rarkins and
viceice
and removed request for
rarkins
|
Currently, for every package we're fetching:
If first 3 are done correctly, seems like we don't need the latter one. |
Churro
reviewed
Nov 22, 2024
There was a problem hiding this comment.
Currently, for every package we're fetching:
* `maven-metadata.xml` * GET the latest POM file (for `homepage`/`sourceUrl`) * HEAD the POM file of the selected/filtered release (often matches with GET of the latest one) * [Maven Central only] HTML index pageIf first 3 are done correctly, seems like we don't need the latter one.
If I'm not mistaken "GET the latest POM file (for homepage/sourceUrl)" is done after populating the list of releases, i.e.., any release that is unknown at this point won't be pulled. Hence, the "[Maven Central only] HTML index page" step is actually second, not last. Do you agree?
Churro
approved these changes
Nov 28, 2024
rarkins
approved these changes
Nov 28, 2024
|
🎉 This PR is included in version 39.35.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ssams
pushed a commit
to ssams/renovate
that referenced
this pull request
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
It doesn't seem necessary now when we're able to obtain all necessary information by querying the corresponding POM file of a particular package version.
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: