Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rebaseWhen): text in PR for new branches with automerge=true #32218

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

PhilipAbed
Copy link
Collaborator

Changes

update the rebaseWhen value even when branches needs creating.

changes are just moving the transform rebaseWhen function above few rows.

Context

in case
automerge=true
the PR text results in:
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

This is not what the documentation says,
after investigating it appears to be only a text issue,
as when rebasing an existing PR the rebasing is handled.

after fix result:
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@PhilipAbed PhilipAbed requested a review from rarkins October 30, 2024 11:29
@rarkins rarkins added this pull request to the merge queue Oct 30, 2024
Merged via the queue into renovatebot:main with commit 56df90b Oct 30, 2024
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 38.135.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants