Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pep621): add support for dependency-groups (PEP 735) #32148

Merged

Conversation

mkniewallner
Copy link
Contributor

Closes #32147.

Changes

Add support for Python dependency-groups, which recently got accepted as part of PEP 735.

Context

As mentioned in the linked discussion, not all tools that support PEP 621 for defining project dependencies support dependency-groups (so far, only uv does AFAIK), but since the feature would only be used by users of tools that support it, it should not be problematic to assume that all tools support it already.

But if you feel like we should take a more defensive approach and only parse dependencies for tools that explicitly support it, happy to update the PR.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Tested over https://github.com/mkniewallner/renovate-uv-dependency-groups.

@mkniewallner mkniewallner marked this pull request as ready for review October 25, 2024 20:38
rarkins
rarkins previously approved these changes Oct 26, 2024
@rarkins rarkins requested a review from secustor October 26, 2024 08:16
lib/modules/manager/pep621/schema.ts Outdated Show resolved Hide resolved
Co-authored-by: Sebastian Poxhofer <[email protected]>
@mkniewallner mkniewallner requested a review from secustor October 26, 2024 11:01
@secustor secustor added this pull request to the merge queue Oct 26, 2024
Merged via the queue into renovatebot:main with commit babd6da Oct 26, 2024
39 checks passed
@mkniewallner mkniewallner deleted the feat/support-python-dependency-groups branch October 26, 2024 16:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants