Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ensure versioning/versioningApi used consistently #31856

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Oct 8, 2024

Changes

Uses versioningApi consistently for each instance of VersioningApi.

Context

It was previously used inconsistently as version, versioning or versioningApi. versioning especially should be reserved for the string ID of the versioning scheme.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested review from viceice and secustor October 8, 2024 15:04
@rarkins rarkins enabled auto-merge October 8, 2024 15:06
@rarkins rarkins added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit c4d4658 Oct 8, 2024
38 checks passed
@rarkins rarkins deleted the chore/versioning-api branch October 8, 2024 15:39
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 38.115.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

zemnmez-renovate-bot added a commit to zemn-me/monorepo that referenced this pull request Oct 9, 2024
##### v38.115.0 (`https://github.com/renovatebot/renovate/releases/tag/38.115.0`)

##### Features

-   add atlaskit package preset and group ([#31872](renovatebot/renovate#31872)) ([f386f7e](renovatebot/renovate@f386f7e))
-   **deps:** update ghcr.io/renovatebot/base-image docker tag to v7.35.0 ([#31870](renovatebot/renovate#31870)) ([bf3f9ff](renovatebot/renovate@bf3f9ff))
-   **sbt-package:** Cache bad URLs during brute-force release fetching ([#31877](renovatebot/renovate#31877)) ([da81a34](renovatebot/renovate@da81a34))

##### Bug Fixes

-   **config/validation:** no jsonata checking for customDatasources ([#31878](renovatebot/renovate#31878)) ([c619d15](renovatebot/renovate@c619d15))

##### Miscellaneous Chores

-   **deps:** update actions/cache action to v4.1.1 ([#31861](renovatebot/renovate#31861)) ([866bdfa](renovatebot/renovate@866bdfa))
-   **deps:** update actions/upload-artifact action to v4.4.2 ([#31863](renovatebot/renovate#31863)) ([3bbbd90](renovatebot/renovate@3bbbd90))
-   **deps:** update actions/upload-artifact action to v4.4.3 ([#31879](renovatebot/renovate#31879)) ([55d8afa](renovatebot/renovate@55d8afa))
-   **deps:** update dependency [@semantic-release/github](https://github.com/semantic-release/github)>[@octokit/plugin-paginate-rest](https://github.com/octokit/plugin-paginate-rest) to v11.3.5 ([#31866](renovatebot/renovate#31866)) ([dbca15d](renovatebot/renovate@dbca15d))
-   **deps:** update pnpm to v9.12.0 ([#31868](renovatebot/renovate#31868)) ([5cce944](renovatebot/renovate@5cce944))
-   ensure versioning/versioningApi used consistently ([#31856](renovatebot/renovate#31856)) ([c4d4658](renovatebot/renovate@c4d4658))

##### Code Refactoring

-   **sbt-package:** Flatten fetching code ([#31836](renovatebot/renovate#31836)) ([81fc756](renovatebot/renovate@81fc756))
github-merge-queue bot pushed a commit to zemn-me/monorepo that referenced this pull request Oct 9, 2024
##### v38.115.0 (`https://github.com/renovatebot/renovate/releases/tag/38.115.0`)

##### Features

-   add atlaskit package preset and group ([#31872](renovatebot/renovate#31872)) ([f386f7e](renovatebot/renovate@f386f7e))
-   **deps:** update ghcr.io/renovatebot/base-image docker tag to v7.35.0 ([#31870](renovatebot/renovate#31870)) ([bf3f9ff](renovatebot/renovate@bf3f9ff))
-   **sbt-package:** Cache bad URLs during brute-force release fetching ([#31877](renovatebot/renovate#31877)) ([da81a34](renovatebot/renovate@da81a34))

##### Bug Fixes

-   **config/validation:** no jsonata checking for customDatasources ([#31878](renovatebot/renovate#31878)) ([c619d15](renovatebot/renovate@c619d15))

##### Miscellaneous Chores

-   **deps:** update actions/cache action to v4.1.1 ([#31861](renovatebot/renovate#31861)) ([866bdfa](renovatebot/renovate@866bdfa))
-   **deps:** update actions/upload-artifact action to v4.4.2 ([#31863](renovatebot/renovate#31863)) ([3bbbd90](renovatebot/renovate@3bbbd90))
-   **deps:** update actions/upload-artifact action to v4.4.3 ([#31879](renovatebot/renovate#31879)) ([55d8afa](renovatebot/renovate@55d8afa))
-   **deps:** update dependency [@semantic-release/github](https://github.com/semantic-release/github)>[@octokit/plugin-paginate-rest](https://github.com/octokit/plugin-paginate-rest) to v11.3.5 ([#31866](renovatebot/renovate#31866)) ([dbca15d](renovatebot/renovate@dbca15d))
-   **deps:** update pnpm to v9.12.0 ([#31868](renovatebot/renovate#31868)) ([5cce944](renovatebot/renovate@5cce944))
-   ensure versioning/versioningApi used consistently ([#31856](renovatebot/renovate#31856)) ([c4d4658](renovatebot/renovate@c4d4658))

##### Code Refactoring

-   **sbt-package:** Flatten fetching code ([#31836](renovatebot/renovate#31836)) ([81fc756](renovatebot/renovate@81fc756))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants