fix(config): set npmToken in npmrc when not in encrypted

[RahulGautamSingh]

Changes

Add npmToken value in the npmrc string even when the npmToken is not within encrypted object

Context

Closes: #31808

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository (locally, with npmToken within encrypted and without it )

[viceice]

I think the existing token handling should be removed then. 🤔

maybe it should be handled in npm manager only? because there's already some kind of code to handle 🤔

[RahulGautamSingh]

I think the existing token handling should be removed then.

Still needed for self-hosted users.

[viceice]

I think the existing token handling should be removed then.

Still needed for self-hosted users.

can't we unify that code? otherwise we risk unexpected behavior in future

[RahulGautamSingh]

can't we unify that code? otherwise we risk unexpected behavior in future

Actually just removing the npmToken & npmrc logic from decryptConfig function and handling it using the newly created setNpmTokenToNpmrc function should work as well. Updating...

[viceice]

LGTM, but needs real repo testing

[RahulGautamSingh]

LGTM, but needs real repo testing

Done ✅

[renovate-release]

🎉 This PR is included in version 39.7.6 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)
• 39.7.6

Your semantic-release bot 📦🚀