Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(http/github): add utility function to fetch raw files #30155

Merged
merged 6 commits into from
Aug 21, 2024
Merged

chore(http/github): add utility function to fetch raw files #30155

merged 6 commits into from
Aug 21, 2024

Conversation

secustor
Copy link
Collaborator

@secustor secustor commented Jul 12, 2024 •
edited
Loading

Changes

add getRawFile which will set the necessary accept header to get a raw file.
If the requested API path is not a single file it will default to the same behavior as application/json

Context

Enables #30155

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@secustor secustor requested a review from viceice July 12, 2024 22:45
viceice
viceice reviewed Jul 13, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/util/http/github.spec.ts Show resolved Hide resolved
@secustor secustor requested a review from viceice July 15, 2024 22:24
@secustor secustor requested a review from viceice July 19, 2024 08:33
viceice
viceice reviewed Jul 26, 2024
View reviewed changes
lib/util/http/github.ts Show resolved Hide resolved
lib/util/http/github.ts Outdated Show resolved Hide resolved
@secustor secustor requested a review from viceice July 31, 2024 22:11
@rarkins rarkins added this pull request to the merge queue Aug 21, 2024
Merged via the queue into renovatebot:main with commit 1f3ab66 Aug 21, 2024
38 checks passed
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.46.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@secustor @renovate-release @viceice @rarkins