Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terragrunt): package name regex order #28739

Merged

Conversation

lstoeferle
Copy link
Contributor

@lstoeferle lstoeferle commented Apr 29, 2024

Changes

I've tried Renovate v37.328.1 in our self-hosted setup. Unfortunately there is still an issue with the .git part... I changed the repository URL resolution to use the correct order of RegExp replacements and changed the test to contain a sub-directory in the source URL. I think now all cases should be covered, since the new repositoryPath variable is used for dep.depName AND dep.packageName.

I'm sorry for overseeing this case while implementing the previous "fix".

Context

Forward fix for #28726

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice added this pull request to the merge queue Apr 29, 2024
Merged via the queue into renovatebot:main with commit 0688e23 Apr 29, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.329.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants