fix(terragrunt): package name regex order #28739
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I've tried Renovate v37.328.1 in our self-hosted setup. Unfortunately there is still an issue with the
.git
part... I changed the repository URL resolution to use the correct order of RegExp replacements and changed the test to contain a sub-directory in the source URL. I think now all cases should be covered, since the newrepositoryPath
variable is used fordep.depName
ANDdep.packageName
.I'm sorry for overseeing this case while implementing the previous "fix".
Context
Forward fix for #28726
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: