privateKey decryption broken since 37.191.1 due to Node.js change #27375
Comments
rarkins
added
type:bug
|
I've confirmed that decryption works in 39.191.0 but fails in 39.191.1. There's a different node version: |
|
Root cause: openpgpjs/openpgpjs#1727 |
|
There appears to be a |
|
Changing the (note: only last line changed) Works around the problem. It does though result in this warning at startup: |
|
If we add the workaround, then we should make it optional. so that only users enable it when using openpgp encryption. |
|
Maybe via our own env? |
|
Problem is people may be broken but not realize it |
|
The affected version should be 37.191.1 and working version is 37.191.0, correct? The title and some comment refers to 39.191.* |
|
I don't see any errors or ambiguities in the title or description of this issue |
Your latest release is "37.202.2". The title says "39.191.1". Surely this is incorrect?
Here the docker image tag is 37.* , you mention 39.* directly above it. |
rarkins
changed the title
|
Thank you! I overlooked the 39 part. Corrected to 37.x, does it make sense now? Also you can use latest versions of Renovate already but you need to supply a node environment variable to revert their decryption padding change |
|
Thanks, was just confused as I was pinning our version to the working one. And I went with the title rather than the text :) |
|
If we're focusing on the issue title: It is not encryption that's failing, but decryption. |
rarkins
changed the title
|
For anyone following this issue, this seems to be fixed as of |
yes, for openpgp. the old RSA decryption is still broken, but hopefully it's not used. |
Discussed in #27355
Originally posted by basz February 16, 2024
How are you running Renovate?
Self-hosted Renovate
If you're self-hosting Renovate, tell us what version of Renovate you run.
37.191.1-full
If you're self-hosting Renovate, select which platform you are using.
github.com
Was this something which used to work for you, and then stopped?
It used to work, and then stopped
Describe the problem
I'm seeing the following errors
Failed to decrypt field token. Please re-encrypt and try again.
I've pinned this down to being introduced as an issue in version 37.191.1 that seems to update node versions. Version 37.190.0 still works with the encrypted token fields.
Relevant debug logs
Logs
Have you created a minimal reproduction repository?
Placeholder value, please select the correct response from the dropdown
The text was updated successfully, but these errors were encountered: