Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible-galaxy/galaxy-collection: sourceUrl is missing #25768

Closed
rarkins opened this issue Nov 14, 2023 Discussed in #25767 · 1 comment · Fixed by #25769
Closed

ansible-galaxy/galaxy-collection: sourceUrl is missing #25768

rarkins opened this issue Nov 14, 2023 Discussed in #25767 · 1 comment · Fixed by #25769
Labels
datasource:galaxy priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality

Comments

@rarkins
Copy link
Collaborator

rarkins commented Nov 14, 2023

Discussed in #25767

Originally posted by Shegox November 14, 2023

How are you running Renovate?

Self-hosted Renovate

If you're self-hosting Renovate, tell us what version of Renovate you run.

37.57.0 as well as main (b633f2c)

If you're self-hosting Renovate, select which platform you are using.

GitHub Enterprise Server

Was this something which used to work for you, and then stopped?

It used to work, and then stopped

Describe the problem

We noticed that updates of ansible-galaxy started to miss the release notes as well as the link to the source package.

This seems to started happening after #25239 introduced the migration to v3 galaxy endpoint. This change as well removed the sourceUrl from the return values of the getReleases() function:

https://github.com/renovatebot/renovate/pull/25239/files#diff-b3225d4da6fcffc251148ba8a4e957e49b4343850ac4c978d1d4cad657799020L119

I assume that this is the current problem, why Renovate can't find the sourceURL for packageUpdates

Relevant debug logs

Logs
2023-11-14T09:44:12.476729077Z DEBUG: requirements.yaml has no dependencies (repository=gh-testing/renovate-test-2, packageFile=collections/requirements.yml)
2023-11-14T09:44:12.480836852Z DEBUG: requirements.yaml has no dependencies (repository=gh-testing/renovate-test-2, packageFile=roles/requirements.yml)
2023-11-14T09:44:12.482626518Z DEBUG: manager extract durations (ms) (repository=gh-testing/renovate-test-2)
2023-11-14T09:44:12.482645445Z        "managers": {
2023-11-14T09:44:12.482647516Z          "helmv3": 0,
2023-11-14T09:44:12.482649534Z          "dockerfile": 5,
2023-11-14T09:44:12.482651504Z          "helm-requirements": 15,
2023-11-14T09:44:12.482653326Z          "ansible-galaxy": 17,
2023-11-14T09:44:12.482655043Z          "helm-values": 17
2023-11-14T09:44:12.482656833Z        }
2023-11-14T09:44:12.482782112Z DEBUG: Found ansible-galaxy package files (repository=gh-testing/renovate-test-2)
2023-11-14T09:44:12.482889335Z DEBUG: Found dockerfile package files (repository=gh-testing/renovate-test-2)
2023-11-14T09:44:12.482960654Z DEBUG: Found 3 package file(s) (repository=gh-testing/renovate-test-2)
2023-11-14T09:44:12.483417212Z  INFO: Dependency extraction complete (repository=gh-testing/renovate-test-2, baseBranch=main)
2023-11-14T09:44:12.483425712Z        "stats": {
2023-11-14T09:44:12.483427580Z          "managers": {
2023-11-14T09:44:12.483429919Z            "ansible-galaxy": {"fileCount": 2, "depCount": 3},
2023-11-14T09:44:12.483431733Z            "dockerfile": {"fileCount": 1, "depCount": 1}
2023-11-14T09:44:12.483433437Z          },
2023-11-14T09:44:12.483435157Z          "total": {"fileCount": 3, "depCount": 4}
2023-11-14T09:44:12.483437010Z        }
2023-11-14T09:44:12.544465047Z DEBUG: Found no satisfying versions with 'pep440' versioning (repository=gh-testing/renovate-test-2)
2023-11-14T09:44:15.697066322Z DEBUG: Found no satisfying versions with 'pep440' versioning (repository=gh-testing/renovate-test-2)
2023-11-14T09:44:15.709007681Z DEBUG: PackageFiles.add() - Package file saved for base branch (repository=gh-testing/renovate-test-2, baseBranch=main)
2023-11-14T09:44:15.709022386Z DEBUG: Package releases lookups complete (repository=gh-testing/renovate-test-2, baseBranch=main)
2023-11-14T09:44:15.709659092Z DEBUG: branchifyUpgrades (repository=gh-testing/renovate-test-2)
2023-11-14T09:44:15.789551305Z DEBUG: detectSemanticCommits() (repository=gh-testing/renovate-test-2)
2023-11-14T09:44:15.789644826Z DEBUG: getCommitMessages (repository=gh-testing/renovate-test-2)
2023-11-14T09:44:15.809533639Z DEBUG: semanticCommits: detected "unknown" (repository=gh-testing/renovate-test-2)
2023-11-14T09:44:15.809558709Z DEBUG: semanticCommits: disabled (repository=gh-testing/renovate-test-2)
2023-11-14T09:44:15.811433008Z DEBUG: 4 flattened updates found: community.general, community.general, community.kubernetes, community.kubernetes (repository=gh-testing/renovate-test-2)
2023-11-14T09:44:15.812124903Z DEBUG: Returning 4 branch(es) (repository=gh-testing/renovate-test-2)
2023-11-14T09:44:15.846038774Z DEBUG: config.repoIsOnboarded=true (repository=gh-testing/renovate-test-2)
2023-11-14T09:44:15.847123807Z DEBUG: packageFiles with updates (repository=gh-testing/renovate-test-2, baseBranch=main)
2023-11-14T09:44:15.847128752Z        "config": {
2023-11-14T09:44:15.847130973Z          "ansible-galaxy": [
2023-11-14T09:44:15.847132764Z            {
2023-11-14T09:44:15.847134554Z              "deps": [
2023-11-14T09:44:15.847136858Z                {
2023-11-14T09:44:15.847139125Z                  "depType": "galaxy-collection",
2023-11-14T09:44:15.847140978Z                  "currentValue": "7.1.0",
2023-11-14T09:44:15.847142903Z                  "depName": "community.general",
2023-11-14T09:44:15.847144986Z                  "datasource": "galaxy-collection",
2023-11-14T09:44:15.847146838Z                  "updates": [
2023-11-14T09:44:15.847148466Z                    {
2023-11-14T09:44:15.847150189Z                      "bucket": "non-major",
2023-11-14T09:44:15.847152061Z                      "newVersion": "7.5.1",
2023-11-14T09:44:15.847153801Z                      "newValue": "7.5.1",
2023-11-14T09:44:15.847155993Z                      "downloadUrl": "https://galaxy.ansible.com/api/v3/plugin/ansible/content/published/collections/artifacts/community-general-7.5.1.tar.gz",
2023-11-14T09:44:15.847158062Z                      "newDigest": "2ef636a758387ca40312672f89b62201d59f8eec05706c2964d8627bf64e646b",
2023-11-14T09:44:15.847159608Z                      "newMajor": 7,
2023-11-14T09:44:15.847161322Z                      "newMinor": 5,
2023-11-14T09:44:15.847162920Z                      "updateType": "minor",
2023-11-14T09:44:15.847165089Z                      "branchName": "renovate/community.general-7.x"
2023-11-14T09:44:15.847166837Z                    },
2023-11-14T09:44:15.847168505Z                    {
2023-11-14T09:44:15.847170132Z                      "bucket": "major",
2023-11-14T09:44:15.847171748Z                      "newVersion": "8.0.2",
2023-11-14T09:44:15.847173263Z                      "newValue": "8.0.2",
2023-11-14T09:44:15.847175026Z                      "downloadUrl": "https://galaxy.ansible.com/api/v3/plugin/ansible/content/published/collections/artifacts/community-general-8.0.2.tar.gz",
2023-11-14T09:44:15.847176648Z                      "newDigest": "3512676225a1a6c2a4666aa64f430b14a0f80e14b8e5fc8324ab6c660df01128",
2023-11-14T09:44:15.847178168Z                      "newMajor": 8,
2023-11-14T09:44:15.847179878Z                      "newMinor": 0,
2023-11-14T09:44:15.847181583Z                      "updateType": "major",
2023-11-14T09:44:15.847183327Z                      "branchName": "renovate/community.general-8.x"
2023-11-14T09:44:15.847185265Z                    }
2023-11-14T09:44:15.847186851Z                  ],
2023-11-14T09:44:15.847188651Z                  "packageName": "community.general",
2023-11-14T09:44:15.847190223Z                  "versioning": "pep440",
2023-11-14T09:44:15.847191843Z                  "warnings": [],
2023-11-14T09:44:15.847193908Z                  "registryUrl": "https://galaxy.ansible.com",
2023-11-14T09:44:15.847196384Z                  "currentVersion": "7.1.0",
2023-11-14T09:44:15.847198968Z                  "isSingleVersion": true,
2023-11-14T09:44:15.847201160Z                  "fixedVersion": "7.1.0"
2023-11-14T09:44:15.847215993Z                },
2023-11-14T09:44:15.847218747Z                {
2023-11-14T09:44:15.847220642Z                  "depType": "galaxy-collection",
2023-11-14T09:44:15.847222154Z                  "currentValue": "1.1.1",
2023-11-14T09:44:15.847223984Z                  "depName": "community.kubernetes",
2023-11-14T09:44:15.847225791Z                  "datasource": "galaxy-collection",
2023-11-14T09:44:15.847227602Z                  "updates": [
2023-11-14T09:44:15.847229195Z                    {
2023-11-14T09:44:15.847230783Z                      "bucket": "non-major",
2023-11-14T09:44:15.847232376Z                      "newVersion": "1.2.1",
2023-11-14T09:44:15.847233938Z                      "newValue": "1.2.1",
2023-11-14T09:44:15.847237722Z                      "downloadUrl": "https://galaxy.ansible.com/api/v3/plugin/ansible/content/published/collections/artifacts/community-kubernetes-1.2.1.tar.gz",
2023-11-14T09:44:15.847239608Z                      "newDigest": "38e064bb32ee86781f0c6e56bd29fcfbaf48180f993e129185eb8420caabf223",
2023-11-14T09:44:15.847241278Z                      "newMajor": 1,
2023-11-14T09:44:15.847242971Z                      "newMinor": 2,
2023-11-14T09:44:15.847244579Z                      "updateType": "minor",
2023-11-14T09:44:15.847246227Z                      "branchName": "renovate/community.kubernetes-1.x"
2023-11-14T09:44:15.847247792Z                    },
2023-11-14T09:44:15.847249382Z                    {
2023-11-14T09:44:15.847251030Z                      "bucket": "major",
2023-11-14T09:44:15.847252807Z                      "newVersion": "2.0.1",
2023-11-14T09:44:15.847254539Z                      "newValue": "2.0.1",
2023-11-14T09:44:15.847256361Z                      "downloadUrl": "https://galaxy.ansible.com/api/v3/plugin/ansible/content/published/collections/artifacts/community-kubernetes-2.0.1.tar.gz",
2023-11-14T09:44:15.847258091Z                      "newDigest": "ca9f014c93d6198a10afa93987e7de4a599e71897b7488fb7c5609e489211494",
2023-11-14T09:44:15.847259630Z                      "newMajor": 2,
2023-11-14T09:44:15.847261626Z                      "newMinor": 0,
2023-11-14T09:44:15.847263169Z                      "updateType": "major",
2023-11-14T09:44:15.847264873Z                      "branchName": "renovate/community.kubernetes-2.x"
2023-11-14T09:44:15.847268370Z                    }
2023-11-14T09:44:15.847270062Z                  ],
2023-11-14T09:44:15.847271747Z                  "packageName": "community.kubernetes",
2023-11-14T09:44:15.847273418Z                  "versioning": "pep440",
2023-11-14T09:44:15.847275077Z                  "warnings": [],
2023-11-14T09:44:15.847276688Z                  "registryUrl": "https://galaxy.ansible.com",
2023-11-14T09:44:15.847278188Z                  "currentVersion": "1.1.1",
2023-11-14T09:44:15.847279808Z                  "isSingleVersion": true,
2023-11-14T09:44:15.847281550Z                  "fixedVersion": "1.1.1"
2023-11-14T09:44:15.847283238Z                }
2023-11-14T09:44:15.847285003Z              ],
2023-11-14T09:44:15.847286896Z              "packageFile": "collections/requirements.yml"
2023-11-14T09:44:15.847288610Z            },

Have you created a minimal reproduction repository?

I have linked to a minimal reproduction in the description above

@rarkins rarkins added type:bug Bug fix of existing functionality priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others datasource:galaxy labels Nov 14, 2023
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 37.59.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
datasource:galaxy priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants