Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(manager/gradle): ignore stdout of artifact updates via stdio convenience option #23088

Merged
merged 3 commits into from
Jul 2, 2023

Conversation

Churro
Copy link
Collaborator

@Churro Churro commented Jul 2, 2023

Changes

PR #20820 introduced a method to redirect stdout to > /dev/null. This approach didn't include Windows. This PR refactors the implementation to rely on options.stdio instead, as this works on all platforms.

This PR also removes the now no longer existing limitation from the README, corrects a typo in the command, and slightly rephrases it to explain renovate's behavior.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Test repo: https://github.com/renovate-demo/5534-1-gradle7-multi-rsocket-requests-lease-examples

Output on Windows (first command with stdout, second without)
DEBUG: Executing command (repository=renovate-demo/5534-1-gradle7-multi-rsocket-requests-lease-examples, branch=renovate/gradle-7.x)
       "command": "gradlew.bat --console=plain -q properties"
DEBUG: exec completed (repository=renovate-demo/5534-1-gradle7-multi-rsocket-requests-lease-examples, branch=renovate/gradle-7.x)
       "durationMs": 4560,
       "stdout": "Building module jaunt-rsocket-requests-lease:1.1.4-feature-oss-SNAPSHOT\r\nBuilding module jaunt-rsocket-requests-lease-idl:1.1.4-feature-oss-SNAPSHOT\r\n\r\n------------------------------------------------------------\r\nRoot project 'jaunt-rsocket-requests-lease-examples-parent'\r\n------------------------
------------------------------------\r\n\r\nallprojects: [root project 'jaunt-rsocket-requests-lease-examples-parent', project ':jaunt-rsocket-requests-lease', project ':jaunt-rsocket-requests-lease-idl']\r\nant: org.gradle.api.internal.project.DefaultAntBuilder@705627a8\r\nantBuilderFactory: org.gradle.api.internal.project.DefaultAntBuilderFactory@555754d3\r\nartifacts: org.gradle.api.internal.artifacts.dsl.DefaultArtifactHandler_Decorated@33c7d22\r\nasDynamicObject: DynamicObject for root project 'jaunt-rsocket-requests-lease-examples-parent'\r\nbaseClassLoaderScope: org.gradle.api.internal.initialization.DefaultClassLoaderScope@3112af37\r\nbuildDir: C:\\renovate-demo\\5534-1-gradle7-multi-rsocket-requests-lease-examples\\build\r\nbuildFile: C:\\renovate-demo\\5534-1-gradle7-multi-rsocket-requests-lease-examples\\build.gradle\r\nbuildPath: :\r\nbuildScriptSource: org.gradle.groovy.scripts.TextResourceScriptSource@7038b5da\r\nbuildscript: org.gradle.api.internal.initialization.DefaultScriptHandler@1f2696c2\r\nchildProjects: {jaunt-rsocket-requests-lease=project ':jaunt-rsocket-requests-lease', jaunt-rsocket-requests-lease-idl=project ':jaunt-rsocket-requests-lease-idl'}\r\nclass: class org.gradle.api.internal.project.DefaultProject_Decorated\r\nclassLoaderScope: org.gradle.api.internal.initialization.DefaultClassLoaderScope@61831143\r\ncomponents: SoftwareComponentInternal set\r\nconfigurationActions: org.gradle.configuration.project.DefaultProjectConfigurationActionContainer@7f132d69\r\nconfigurationTargetIdentifier: org.gradle.configuration.ConfigurationTargetIdentifier$1@5b5c4eab\r\nconfigurations: configuration container\r\nconvention: org.gradle.internal.extensibility.DefaultConvention@6effa67f\r\ncrossProjectModelAccess: org.gradle.api.internal.project.DefaultCrossProjectModelAccess@4544ade4\r\ndefaultTasks: [clean, build]\r\ndeferredProjectConfiguration: org.gradle.api.internal.project.DeferredProjectConfiguration@235aa840\r\ndependencies: org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler_Decorated@1a4a8396\r\ndependencyFactory: org.gradle.api.internal.artifacts.DefaultDependencyFactory@99502fe\r\ndependencyLocking: org.gradle.internal.locking.DefaultDependencyLockingHandler_Decorated@695eb5a5\r\ndependencyManagementPluginVersion: 1.0.11.RELEASE\r\ndependencyMetaDataProvider: org.gradle.internal.service.scopes.ProjectScopeServices$ProjectBackedModuleMetaDataProvider@1f300866\r\ndepth: 0\r\ndescription: null\r\ndetachedState: false\r\ndisplayName: root project 'jaunt-rsocket-requests-lease-examples-parent'\r\next: org.gradle.internal.extensibility.DefaultExtraPropertiesExtension@51a86e25\r\nextensions: org.gradle.internal.extensibility.DefaultConvention@6effa67f\r\nfileOperations: org.gradle.api.internal.file.DefaultFileOperations@700b041c\r\nfileResolver: org.gradle.api.internal.file.BaseDirFileResolver@6c647425\r\ngitPluginVersion: 0.13.0\r\ngitVersion: com.palantir.gradle.gitversion.GitVersionPlugin$1@738832f7\r\ngoogleJavaFormatPluginVersion: 0.9\r\ngradle: build 'jaunt-rsocket-requests-lease-examples-parent'\r\ngroup: com.jauntsdn.rsocket\r\nhdrHistogramVersion: 2.1.12\r\nidentityPath: :\r\ninheritedScope: org.gradle.internal.extensibility.ExtensibleDynamicObject$InheritedDynamicObject@61c3b3e5\r\ninternalStatus: property(java.lang.Object, fixed(class java.lang.String, release))\r\nlayout: org.gradle.api.internal.file.DefaultProjectLayout@49407025\r\nlistenerBuildOperationDecorator: org.gradle.configuration.internal.DefaultListenerBuildOperationDecorator@6caf074\r\nlogbackVersion: 1.2.11\r\nlogger: org.gradle.internal.logging.slf4j.OutputEventListenerBackedLogger@346775d0\r\nlogging: org.gradle.internal.logging.services.DefaultLoggingManager@4847b422\r\nmodel: root project 'jaunt-rsocket-requests-lease-examples-parent'\r\nmodelIdentityDisplayName: null\r\nmodelRegistry: org.gradle.model.internal.registry.DefaultModelRegistry@24c2457\r\nname: jaunt-rsocket-requests-lease-examples-parent\r\nnormalization: org.gradle.normalization.internal.DefaultInputNormalizationHandler_Decorated@53d42d3a\r\nobjects: org.gradle.api.internal.model.DefaultObjectFactory@5c121b65\r\nowner: root project 'jaunt-rsocket-requests-lease-examples-parent'\r\nparent: null\r\nparentIdentifier: null\r\npath: :\r\npluginContext: false\r\npluginManager: org.gradle.api.internal.plugins.DefaultPluginManager_Decorated@29815261\r\nplugins: [org.gradle.api.plugins.HelpTasksPlugin@30bc14d4, org.gradle.buildinit.plugins.BuildInitPlugin@7f322bf, org.gradle.buildinit.plugins.WrapperPlugin@3f37a0fe, com.palantir.gradle.gitversion.GitVersionRootPlugin@2b2276df, com.palantir.gradle.gitversion.GitVersionPlugin@23ca7f05, com.github.benmanes.gradle.versions.VersionsPlugin@3861a3d4]\r\nprintVersion: task ':printVersion'\r\nprocessOperations: org.gradle.process.internal.DefaultExecActionFactory$DecoratingExecActionFactory@4a0ca59a\r\nproject: root project 'jaunt-rsocket-requests-lease-examples-parent'\r\nprojectConfigurator: org.gradle.api.internal.project.BuildOperationCrossProjectConfigurator@3843fc1c\r\nprojectDir: C:\\renovate-demo\\5534-1-gradle7-multi-rsocket-requests-lease-examples\r\nprojectEvaluationBroadcaster: ProjectEvaluationListener broadcast\r\nprojectEvaluator: org.gradle.configuration.project.LifecycleProjectEvaluator@74460142\r\nprojectPath: :\r\nproperties: {...}\r\nprotobufPluginVersion: 0.8.19\r\nproviders: org.gradle.api.internal.provider.DefaultProviderFactory_Decorated@577757f1\r\nrSocketVersion: 1.1.4\r\nrepositories: repository container\r\nresources: org.gradle.api.internal.resources.DefaultResourceHandler@78f818f0\r\nrootDir: C:\\renovate-demo\\5534-1-gradle7-multi-rsocket-requests-lease-examples\r\nrootProject: root project 'jaunt-rsocket-requests-lease-examples-parent'\r\nrootScript: false\r\nscript: false\r\nscriptHandlerFactory: org.gradle.api.internal.initialization.DefaultScriptHandlerFactory@5f7ca8ef\r\nscriptPluginFactory: org.gradle.configuration.ScriptPluginFactorySelector@1bf4fe53\r\nserviceRegistryFactory: org.gradle.internal.service.scopes.ProjectScopeServices$$Lambda$976/0x0000000801398000@7651fa03\r\nservices: ProjectScopeServices\r\nslf4jVersion: 1.7.36\r\nstandardOutputCapture: org.gradle.internal.logging.services.DefaultLoggingManager@4847b422\r\nstate: project state 'EXECUTED'\r\nstatus: release\r\nsubprojects: [project ':jaunt-rsocket-requests-lease', project ':jaunt-rsocket-requests-lease-idl']\r\ntaskThatOwnsThisObject: null\r\ntasks: task set\r\nversion: 1.1.4\r\nversionDetails: com.palantir.gradle.gitversion.GitVersionPlugin$2@4ed643a1\r\nversionsPluginVersion: 0.42.0\r\n",
       "stderr": ""
DEBUG: Setting CONTAINERBASE_CACHE_DIR to C:/renovate/cache/containerbase (repository=renovate-demo/5534-1-gradle7-multi-rsocket-requests-lease-examples, branch=renovate/gradle-7.x)
DEBUG: Falling back to binarySource=global (repository=renovate-demo/5534-1-gradle7-multi-rsocket-requests-lease-examples, branch=renovate/gradle-7.x)
DEBUG: Executing command (repository=renovate-demo/5534-1-gradle7-multi-rsocket-requests-lease-examples, branch=renovate/gradle-7.x)
       "command": "gradlew.bat --console=plain -q :dependencies :jaunt-rsocket-requests-lease:dependencies :jaunt-rsocket-requests-lease-idl:dependencies --write-locks"
DEBUG: exec completed (repository=renovate-demo/5534-1-gradle7-multi-rsocket-requests-lease-examples, branch=renovate/gradle-7.x)
       "durationMs": 4898,
       "stdout": "",
       "stderr": ""
DEBUG: Returning updated Gradle dependency lockfiles (repository=renovate-demo/5534-1-gradle7-multi-rsocket-requests-lease-examples, branch=renovate/gradle-7.x)

Sorry, something went wrong.

Churro added 2 commits July 2, 2023 16:45

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
… convenience option
rarkins
rarkins previously approved these changes Jul 2, 2023
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

@viceice viceice added this pull request to the merge queue Jul 2, 2023
Merged via the queue into renovatebot:main with commit 4dc6d69 Jul 2, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.159.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants