Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform/bitbucket): handle author is also default reviewer #22978

Merged

Conversation

setchy
Copy link
Collaborator

@setchy setchy commented Jun 26, 2023

Changes

Updates sanitizeReviewers to handle scenario where the PR Author is also a default repository reviewer

Context

Discovered during local testing while working on another feature request.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@setchy setchy added the platform:bitbucket Bitbucket Cloud platform label Jun 26, 2023
@setchy setchy changed the title feature(platform/bitbucket): handle author is also default reviewer feat(platform/bitbucket): handle author is also default reviewer Jun 26, 2023
@setchy setchy requested review from rarkins and viceice June 26, 2023 11:14
@rarkins rarkins added this pull request to the merge queue Jun 26, 2023
Merged via the queue into renovatebot:main with commit 96c06e5 Jun 26, 2023
@setchy setchy deleted the feature/bitbucket-handle-reviewer-and-author branch June 26, 2023 11:51
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.142.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform:bitbucket Bitbucket Cloud platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants