Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): allow unstable updates within same major #22955

Merged
merged 3 commits into from
Jun 24, 2023

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jun 24, 2023

Changes

Allows unstable-to-unstable updates within the same major range for Node versioning, e.g. to allow 20.3.0 -> 20.3.1 updates.

Context

Fixes #22934

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested review from secustor and viceice June 24, 2023 07:05
@rarkins rarkins enabled auto-merge June 24, 2023 07:06
@rarkins
Copy link
Collaborator Author

rarkins commented Jun 24, 2023

@zharinov can you take a look here? I would be surprised if these lines are not covered already

viceice
viceice previously approved these changes Jun 24, 2023
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs coverage?

@rarkins
Copy link
Collaborator Author

rarkins commented Jun 24, 2023

Now seems good

@rarkins rarkins added this pull request to the merge queue Jun 24, 2023
Merged via the queue into main with commit 5db51f5 Jun 24, 2023
@rarkins rarkins deleted the fix/22934-node-unstable branch June 24, 2023 08:54
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.141.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants