Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default platformCommit to true when in app mode #21318

Closed
Tracked by #21134
rarkins opened this issue Apr 4, 2023 · 0 comments
Closed
Tracked by #21134

Default platformCommit to true when in app mode #21318

rarkins opened this issue Apr 4, 2023 · 0 comments
Labels
breaking Breaking change, requires major version bump platform:github GitHub Platform priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Apr 4, 2023

Describe the proposed change(s).

We should change platformCommit default from false to true when in app mode.

This is perhaps by changing it from boolean to enum: auto (enable if in app mode), enabled, disabled.

It only applies to GitHub, and has been working reliably for the hosted app. It has no benefit that I'm aware of when using a PAT, so better to leave it as false there (it's more efficient without).
@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others breaking Breaking change, requires major version bump status:ready labels Apr 4, 2023
@viceice viceice mentioned this issue Apr 4, 2023
Closed
28 tasks
@HonkingGoose HonkingGoose added the platform:github GitHub Platform label Apr 4, 2023
@rarkins rarkins closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
breaking Breaking change, requires major version bump platform:github GitHub Platform priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rarkins @HonkingGoose