-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support private Docker registries in bitbucket-pipelines.yml #13555
Comments
I don't think this can be easily covered by regex, as the keys can be in any order. We should instead parse the file as yaml. |
Please note that the syntax could appear within the steps as well: image:
name: "my.custom-domain.com/myimage:1.0.0"
username: my-user
password: my-password
pipelines:
default:
- step:
name: Echo
script:
- echo "Hello World"
- step:
name: Important
image:
name: "my.custom-domain.com/importantimg:1.0.0"
username: my-user
password: my-password
script:
- important-cli |
As a workaround I added this regexManager and it seems to work: {
"regexManagers": [
{
"fileMatch": ["^bitbucket-pipelines.yml$"],
"matchStrings": [
"\\s*-?\\s?image:\\s*\\n\\s+name:\\s+\"?(?<depName>[a-z/.-]+)(?::(?<currentValue>[a-z0-9.-]+))?(?:@(?<currentDigest>sha256:[a-f0-9]+))?"
],
"datasourceTemplate": "docker",
"versioningTemplate": "docker"
}
]
} |
➕ to improving we're using a slight modification to the above workaround {
"regexManagers": [
{
"matchManagers": ["bitbucket-pipelines"],
"matchStrings": [
"\\s*-?\\s?image:\\s*\\n\\s+name:\\s+\"?(?<depName>[a-z/.-]+)(?::(?<currentValue>[a-z0-9.-]+))?(?:@(?<currentDigest>sha256:[a-f0-9]+))?"
],
"datasourceTemplate": "docker",
"versioningTemplate": "docker"
}
]
} |
This page contains the full Docker image yaml spec used by Bitbucket Pipelines |
🎉 This issue has been resolved in version 35.25.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What would you like Renovate to be able to do?
Bitbucket pipelines supports private Docker registries. This images are not hooked up by renovate.
Example:
Checking for
image: "my.custom-domain.com/myimage:1.0.0"
works as expected.See: Using private build images
If you have any ideas on how this should be implemented, please tell us here.
Improve the current regex
Is this a feature you are interested in implementing yourself?
No
The text was updated successfully, but these errors were encountered: