Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [skip ci] to pin dependency PR #1319

Closed
tinovyatkin opened this issue Dec 20, 2017 · 5 comments
Closed

Add [skip ci] to pin dependency PR #1319

tinovyatkin opened this issue Dec 20, 2017 · 5 comments
Labels
priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)

Comments

@tinovyatkin
Copy link

[skip ci] is supported by majority of CI on the market and will allow to same some resources by not running pin dependency PRs on CI (as it makes no sense).

@rarkins
Copy link
Collaborator

rarkins commented Dec 20, 2017

I would support this as an option but not as default behaviour.

For perspective, pinning is usually done once so quickly becomes only a small fraction of total CI time on a project after Renovate is installed.

It can also happen that the pin dependencies PR can fail CI even if the previous master commit it was branched off passed. This happens if a direct or indirect dependency release within range broke things since the last commit. By skipping CI you would not be aware of this break until some time later and it would look like Renovate’s fault.

@rarkins rarkins added type:feature Feature (new functionality) priority-4-low Low priority, unlikely to be done unless it becomes important to more people ready labels Dec 20, 2017
@rarkins
Copy link
Collaborator

rarkins commented Dec 20, 2017

I was typing on mobile earlier, please let me add "thank you for your suggestions!". It's great to get feedback.

As mentioned above, I would suggest to make this opt-in, and also via a preset to hide any complexity. I'm thinking that a generic solution for #777 and this could be good. e.g. letting users customise commit message "bodies". In this case it would mean adding [skip ci] to the commit message body. Question is whether to support more than one at once, e.g. a DCO signoff and skip CI.

@tinovyatkin
Copy link
Author

Well, let see from a different perspective - for example, we are on Github model - ie, our master is protected branch and our CI deploys everything from master after successful builds.

In that case adding whatever new dependency in a PR (or manual upgrade via yarn upgrade that breaks pinning) will result in new PR and second deploy from the same codebase.

I think there a lot of use cases for [skip ci] like dependencies that for sure will not change code (non fixing linters or @type/* for example or even all devDependencies in some projects) and having an option to always skip CI in that updates will be very useful to unload CI from no-sense builds.

@rarkins
Copy link
Collaborator

rarkins commented Dec 20, 2017

I agree that adding the option to easily skip CI is definitely useful. And via presets we can make the various use cases easy to add as they are discovered.

@rarkins
Copy link
Collaborator

rarkins commented Dec 25, 2017

This can now be accomplished if you add the preset ":pinSkipCi" to your extends array.

@rarkins rarkins closed this as completed Dec 25, 2017
@rarkins rarkins removed the ready label Dec 25, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

2 participants