-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add [skip ci] to pin dependency PR #1319
Comments
I would support this as an option but not as default behaviour. For perspective, pinning is usually done once so quickly becomes only a small fraction of total CI time on a project after Renovate is installed. It can also happen that the pin dependencies PR can fail CI even if the previous master commit it was branched off passed. This happens if a direct or indirect dependency release within range broke things since the last commit. By skipping CI you would not be aware of this break until some time later and it would look like Renovate’s fault. |
I was typing on mobile earlier, please let me add "thank you for your suggestions!". It's great to get feedback. As mentioned above, I would suggest to make this opt-in, and also via a preset to hide any complexity. I'm thinking that a generic solution for #777 and this could be good. e.g. letting users customise commit message "bodies". In this case it would mean adding [skip ci] to the commit message body. Question is whether to support more than one at once, e.g. a DCO signoff and skip CI. |
Well, let see from a different perspective - for example, we are on Github model - ie, our In that case adding whatever new dependency in a PR (or manual upgrade via I think there a lot of use cases for |
I agree that adding the option to easily skip CI is definitely useful. And via presets we can make the various use cases easy to add as they are discovered. |
This can now be accomplished if you add the preset |
[skip ci]
is supported by majority of CI on the market and will allow to same some resources by not runningpin dependency
PRs on CI (as it makes no sense).The text was updated successfully, but these errors were encountered: