Cache decorator noisily logs lookup errors

[rarkins]

How are you running Renovate?

• WhiteSource Renovate hosted app on github.com
• Self hosted

Describe the bug

The new cache decorator logs lookup errors which were previously ignored quietly.

Relevant debug logs

Click me to see logs

Here is one example:

{
code: ENOTFOUND, 
message: getaddrinfo ENOTFOUND charts.truecharts.com, 
name: RequestError, 
options: {
headers: [Object], 
http2: False, 
method: GET, 
password: , 
url: https://charts.truecharts.com/index.yaml, 
username: 
}, 
stack: 
RequestError: getaddrinfo ENOTFOUND charts.truecharts.com
    at ClientRequest.<anonymous> (/home/ubuntu/renovateapp/node_modules/renovate/node_modules/got/dist/source/core/index.js:956:111)
    at Object.onceWrapper (events.js:422:26)
    at ClientRequest.emit (events.js:327:22)
    at ClientRequest.EventEmitter.emit (domain.js:467:12)
    at ClientRequest.origin.emit (/home/ubuntu/renovateapp/node_modules/renovate/node_modules/@szmarczak/http-timer/dist/source/index.js:39:20)
    at TLSSocket.socketErrorListener (_http_client.js:469:9)
    at TLSSocket.emit (events.js:315:20)
    at TLSSocket.EventEmitter.emit (domain.js:467:12)
    at emitErrorNT (internal/streams/destroy.js:106:8)
    at emitErrorCloseNT (internal/streams/destroy.js:74:3)
    at processTicksAndRejections (internal/process/task_queues.js:80:21)
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:67:26)
, 
timings: {
error: 1623766414905, 
lookup: 1623766414905, 
phases: [Object], 
socket: 1623766414760, 
start: 1623766414760
}
}

Have you created a minimal reproduction repository?

Please read the minimal reproductions documentation to learn how to make a good minimal reproduction repository.

• I have provided a minimal reproduction repository
• I don't have time for that, but it happens in a public repository I have linked to
• I don't have time for that, and cannot share my private repository
• The nature of this bug means it's impossible to reproduce publicly

Additional context

I think we should only log errors in the cache's own logic and not ones returned from datasources.

[renovate-release]

🎉 This issue has been resolved in version 25.44.1 🎉

The release is available on:

• GitHub release
• 25.44.1

Your semantic-release bot 📦🚀