GitLab external job "renovate/stability-days" treated as passing status check even when tests fail #27111
Replies: 5 comments 13 replies
-
|
Needs logs the next time it happens |
Beta Was this translation helpful? Give feedback.
-
|
We are also occasionally getting this issue, the stability days job being treated as its own pipeline. Here are the relevant logs from a PR that was merged with a nonpassing pipeline |
Beta Was this translation helpful? Give feedback.
-
|
The same started to happen to us last week |
Beta Was this translation helpful? Give feedback.
-
|
There's still no log showing renovate automerging. The last log above says it's configured for automerge which is true, but that's not the same as the actual automerge. We don't know if it was done by renovate itself or GitLab platform automerge |
Beta Was this translation helpful? Give feedback.
-
|
I'll add |
Beta Was this translation helpful? Give feedback.
-
|
Hi there, This issue or discussion is missing some logs, making it difficult or impossible to help you. Depending on which situation applies follow one, some or all of these instructions. No logs at allIf you haven't posted any log yet, we need you to find and copy/paste the log into the issue template. Finding logs on hosted appSelect me to read instructionsIf you use the Renovate app (GitHub):
Finding logs when self-hostingSelect me to read instructionsIf you're running self-hosted, run with Insufficient logsSelect me to read instructionsIf you already gave us a log, and the Renovate team said it's not enough, then follow the instructions from the No logs at all section. Formatting your logsSelect me to read instructionsPlease put your logs in a Good luck, The Renovate team |
Beta Was this translation helpful? Give feedback.
-
|
Hi, please format any copy/pasted code or logs so they're readable. You can find a Markdown code formatting guide here as well as some GitHub-specific information formatting code blocks here. Thanks, the Renovate team |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment has been hidden.
This comment has been hidden.
-
|
I think a possible problem could be that Renovate try to retrieve renovate/lib/modules/platform/gitlab/index.ts Lines 1043 to 1058 in a890d48 Instead of:
it should be:
|
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the info. If this is a recurring problem for all GitLab users then we should solve it properly and not only in an experimental variable. Do you think our defaults need changing? |
Beta Was this translation helpful? Give feedback.
-
|
On my self-hosted Gitlab instance, delay between branch creation and pipeline creation is between 0.5 second and 2 seconds. An idea to minimize this problem is to add a polling with a new max_attempt parameter (default value: 5). you can do something like this: But if the Gitlab instance is overloaded, the problem will still occurs. An other idea to prevent unwanted merges is to use Draft status of PR.
|
Beta Was this translation helpful? Give feedback.
-
|
I made more tests, I confirm that default delay of 1 second ( |
Beta Was this translation helpful? Give feedback.
-
|
I propose implementing a polling in |
Beta Was this translation helpful? Give feedback.
-
|
I create this draft PR #32692 . Before the patch , Renovate status check create new unwanted pipelines: After the patch (with |
Beta Was this translation helpful? Give feedback.
-
How are you running Renovate?
Self-hosted Renovate
If you're self-hosting Renovate, tell us what version of Renovate you run.
v37.153.2 (Mend Renovate 6.10.0)
If you're self-hosting Renovate, select which platform you are using.
GitLab self-hosted, v16.7.4
Was this something which used to work for you, and then stopped?
It used to work, and then stopped
Describe the problem
Similar to: #7800
We are experiencing that Renovate is automerging failing pipelines if the "renovate/stability-days" job is running green (same as @XFNeo mentioned). This does happen occasionally, but seldom, and is not something I can reproduce easily. Here is a recent example, notice how the pipeline is merged before our custom pipeline is finished, Renovate never seems to consider the result of our pipeline:
Here is our relevant Renovate config:
{ "minimumReleaseAge": "3 days", "packageRules": [ { "matchManagers": ["npm"], "matchUpdateTypes": ["minor", "patch"], "automerge": true, "gitLabIgnoreApprovals": true } ] }Relevant debug logs
Sorry, I didn't have
LOG_LEVEL=debug, so I got no relevant logs.Have you created a minimal reproduction repository?
I have explained in the description why a minimal reproduction is impossible
Beta Was this translation helpful? Give feedback.
All reactions