Skip to content

Commit

Permalink
ci: use node v16 and test v18 (#18584)
Browse files Browse the repository at this point in the history
  • Loading branch information
viceice authored Oct 26, 2022
1 parent 887cabe commit fbaac11
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ concurrency:
env:
# Currently no way to detect automatically (#8153)
DEFAULT_BRANCH: main
NODE_VERSION: 14
NODE_VERSION: 16
DRY_RUN: true

jobs:
Expand All @@ -38,7 +38,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node-version: [14, 16]
node-version: [14, 16, 18]
# skip macOS and Windows test on pull requests without 'ci:fulltest' label
include: >-
${{ fromJSON((github.event_name != 'pull_request' || contains(github.event.pull_request.labels.*.name, 'ci:fulltest')) && '[{
Expand All @@ -50,7 +50,7 @@ jobs:
}]' || '[]') }}
env:
coverage: ${{ matrix.os == 'ubuntu-latest' && (matrix.node-version == 14 || matrix.node-version == 16) }}
coverage: ${{ matrix.os == 'ubuntu-latest' && (matrix.node-version == 16 || matrix.node-version == 18) }}
NODE_VERSION: ${{ matrix.node-version }}

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ on:
required: false

env:
NODE_VERSION: 14
NODE_VERSION: 16
GIT_SHA: ${{ github.event.client_payload.sha }}
NPM_VERSION: ${{ github.event.client_payload.version }}
NPM_TAG: ${{ github.event.client_payload.tag }}
Expand Down

0 comments on commit fbaac11

Please sign in to comment.