From 41249bf9ecf07cac9002fd44cb7447f0ab924cd8 Mon Sep 17 00:00:00 2001 From: Andrei Matei Date: Thu, 17 Nov 2022 18:29:54 -0500 Subject: [PATCH] authccl: remove useless noise from test This test was enabling some logging, without that actually mattering for the test. Besides being more or less useless, this code is about to become confusing; I'm separately making the test work in multi-tenant mode, and there the logging would need to be enabled on a different server for it to still make any sense. This patch removes it instead. Release note: None Epic: None --- pkg/ccl/testccl/authccl/auth_test.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/pkg/ccl/testccl/authccl/auth_test.go b/pkg/ccl/testccl/authccl/auth_test.go index 4f7a2dff4b42..348d9c36e927 100644 --- a/pkg/ccl/testccl/authccl/auth_test.go +++ b/pkg/ccl/testccl/authccl/auth_test.go @@ -184,13 +184,7 @@ func jwtRunTest(t *testing.T, insecure bool) { base.TestServerArgs{Insecure: insecure, SocketFile: maybeSocketFile}) defer s.Stopper().Stop(context.Background()) - // Enable conn/auth logging. - // We can't use the cluster settings to do this, because - // cluster settings propagate asynchronously. testServer := s.(*server.TestServer) - pgServer := s.(*server.TestServer).PGServer().(*pgwire.Server) - pgServer.TestingEnableConnLogging() - pgServer.TestingEnableAuthLogging() if _, err := conn.ExecContext(context.Background(), fmt.Sprintf(`CREATE USER %s`, username.TestUser)); err != nil { t.Fatal(err)