Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Potential Solution: Showing the changelog #564

Open
DericHuynh opened this issue May 20, 2021 · 3 comments
Open

Potential Solution: Showing the changelog #564

DericHuynh opened this issue May 20, 2021 · 3 comments

Comments

@DericHuynh
Copy link

DericHuynh commented May 20, 2021

Problem:
It should be clear that the problem with the new build system is that it doesn't seem to have an easy way of giving you the changelog of all commits between the current and previous version. It only shows you the commit that triggered the build for the current version.

Useful Links
Here is a list of the releases.
https://github.com/CleverRaven/Cataclysm-DDA/releases

Here is a list of the commits on master.
https://github.com/CleverRaven/Cataclysm-DDA/commits/master

Solution:
Goto https://github.com/CleverRaven/Cataclysm-DDA/releases and notice the Commit UID

Example2

If you click on the commit UID link, you can get to the page of the specific commit that triggered the build. See this?

ExampleOne

That is a link to the parent node, the previous commit this commit was built off of, and by creating a loop that continuously goes through each parent node until you reach the node of the previous build, you can add the title of each commit to a list to build a changelog. The commit UIDs can be compared by checking the commit UID of the node you're currently one and the commit UID of the previous release.

Example2 - Copy

Once you get to the last node, you can exit the loop and use the changelog list.

TLDR: You can make a web crawler that goes through all commits between two releases by going through the parent node links of each commit and use that as the changelog.

@DericHuynh DericHuynh changed the title Potential way to show changelog Potential Solution: Showing the changelog May 20, 2021
@remyroy
Copy link
Owner

remyroy commented May 21, 2021

Good idea. I don't see the launcher doing this for every user though. I would much rather see a centralized or hosted service doing this so the launcher could pull from there.

@ZhilkinSerg
Copy link
Contributor

Changelog should be written in release notes. Possible approach is rather obvious - show list of commit descriptions between current and previous build. Somebody just needs to work on this.

@Cenness
Copy link

Cenness commented May 23, 2021

That is a link to the parent node, the previous commit this commit was built off of, and by creating a loop that continuously goes through each parent node until you reach the node of the previous build, you can add the title of each commit to a list to build a changelog.

There is a git log command for that, no need to manually loop over. It even accepts tags:

# git log --oneline cdda-experimental-2021-05-22-0734..cdda-experimental-2021-05-23-0732
32f7fafc5f (tag: cdda-experimental-2021-05-23-0732) Merge pull request #48997 from BrettDong/osx-build
47b0658754 (tag: cdda-experimental-2021-05-23-0527) Merge pull request #48958 from eltank/no_leatherworking
1e7a8060a9 update unit test for crafting helmet_scavenger
dedfbe980c Fix compile error on macOS with l10n disabled
f2f07b93e6 Remove leatherworking proficiency from recipes that shouldn't need it

Edit: Mostly ready to use github action, dozens of them

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants