Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CI scripts more uniform #38

Open
2 tasks
septract opened this issue Jul 5, 2024 · 1 comment
Open
2 tasks

Make CI scripts more uniform #38

septract opened this issue Jul 5, 2024 · 1 comment

Comments

@septract
Copy link
Collaborator

septract commented Jul 5, 2024

Problem: We currently have two CI scripts:

  • cn-tutorial/check.sh - this runs the examples in cn-tutorial/src/example, which are used in the tutorial itself
  • cn-tutorial/src/example-archive/check-all.sh - this runs all the examples in the example archive.

These scripts are gratuitously different from each other. Eg the first one counts the number of failures, and the second one doesn't.

Unifying the scripts is slightly annoying because the tutorial scripts are categorized by name, while the example archive scripts are categorized by subdirectory. But they should have the same capabilities and interface.

Desired resolution

  • Scripts have the same capabilities and interface
  • Scripts are called through a single top-level make check target (see Add make check target #14 as a starting point)
@bcpierce00
Copy link
Collaborator

bcpierce00 commented Jul 7, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants