Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add twoslash to docs #447

Closed
JonnyBurger opened this issue Jun 13, 2021 · 8 comments · Fixed by #481
Closed

Add twoslash to docs #447

JonnyBurger opened this issue Jun 13, 2021 · 8 comments · Fixed by #481
Assignees
Labels
🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt

Comments

@JonnyBurger
Copy link
Member

JonnyBurger commented Jun 13, 2021

Issuehunt badges

This could be very cool for the docs

https://www.npmjs.com/package/docusaurus-preset-shiki-twoslash


IssueHunt Summary

frencojobs frencojobs has been rewarded.

Backers (Total: $162.00)

Submitted pull Requests


Tips

@frencojobs
Copy link
Contributor

While working on this, I've found out that there are certain things that need to be fixed before we add twoslash to the documentation. For example, implicit React imports in tsx and jsx code blocks, jsx blocks not being highlighted properly, etc. I've already opened a bunch of issues on the twoslash repo. Before then, this feature is probably blocked.

I've also submitted a PR (#465) that does nothing but add a tsconfig.json so that docusaurus theme imports don't bother as errors in your IDE of choice.

@JonnyBurger
Copy link
Member Author

Oh ok, thanks a lot for investigating it! That means JSX is not well supported yet then?

No problem, let's integrate it when it's stable.
In the meanwhile, your other PR was merged 🤝

@issuehunt-oss
Copy link

issuehunt-oss bot commented Jun 23, 2021

@jonnyburger has funded $100.00 to this issue.


@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Jun 23, 2021
@frencojobs
Copy link
Contributor

Hi @JonnyBurger, let me work on this. I've been keeping myself a tad active on the twoslash repo and have pointed bugs to and fixed, to work best with current docs.

@Iamshankhadeep
Copy link
Contributor

@frencojobs I am assigning you this issue. All the best 🔥

@issuehunt-oss
Copy link

issuehunt-oss bot commented Jun 30, 2021

@jonnyburger has funded $12.00 to this issue.


@issuehunt-oss
Copy link

issuehunt-oss bot commented Jun 30, 2021

@jonnyburger has funded $50.00 to this issue.


@issuehunt-oss
Copy link

issuehunt-oss bot commented Jun 30, 2021

@jonnyburger has rewarded $145.80 to @frencojobs. See it on IssueHunt

  • 💰 Total deposit: $162.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $16.20

@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants