feat: Allow customized filter to be passed from external source #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my use case, I am utilizing esbuild in development mode and would like to externalize for the
react
andreact-dom
packages. However, I do not want to externalize the nested packages likereact/jsx-runtime
andreact/jsx-dev-runtime.
Currently, the
makeFilter
function defaults to a positive match for all cases, includingreact/jsx-runtime
andreact/jsx-dev-runtime
. We have a corresponding test case available here.To address this, I have introduced the ability to pass externals as regrex and customize by myself instead, allowing for customization.
This pull request aims to implement this enhancement and improve the flexibility of the
EsmExternalsPlugin
.Thank you for your consideration.