fix(node-modules-polyfill): replace rollup-plugin-node-polyfills with rollup-plugin-polyfill-node

[MichaelDeBoey]

Re-submission of #19

This still has the same problem as @connorjclark pointed out in #19 (comment) (see also #28 for the bug issue)

Cannot read directory "\x00polyfill-node._stream_duplex": invalid argument

@remorses @connorjclark If you have any idea what the problem is & can point me into the right direction, I'm happy to update this PR

Maybe the problem is even deeper & we should look at @FredKSchott's rollup-plugin-polyfill-node to solve it? 🤔

---

Tagging @connorjclark @giuseppeg @ice1000 @imranbarbhuiya @i7eo @matikucharski @p-m-p as you all were interested in my first PR

Closes #18 for real now

[remorses]

The problem is that to use those polyfill you have to reimplement this resolver: https://github.com/FredKSchott/rollup-plugin-polyfill-node/blob/main/src/index.ts#L40

That's because the polyfills are importing code from those paths

I am not really a rollup expert so i don't know how to translate it to esbuild 1 to 1

[MichaelDeBoey]

to use those polyfill you have to reimplement this resolver: https://github.com/FredKSchott/rollup-plugin-polyfill-node/blob/main/src/index.ts#L40

I am not really a rollup expert so i don't know how to translate it to esbuild 1 to 1

@FredKSchott could you maybe point us into the right direction?

@remorses Can you think of any other solution to fix it? Maybe we shouldn't use rollup-plugin-polyfill-node but have the polyfills in another way available?

[p-m-p]

@MichaelDeBoey I presume you tagged me as I referenced this from my issue on the Remix repo.

I did look at your PR here when I raised that issue and think if you add another onLoad in the setup to namespace the modules prefixed with \0polyfill-node. and resolve them like is done here https://github.com/FredKSchott/rollup-plugin-polyfill-node/blob/main/src/index.ts#L75 it could probably work with some tweaking. Not all of the modules are in the modules map, some exist only in the exports of the polyfills file.

Probably not a helpful observation at this point but I do think it would be more beneficial to extract the polyfills properly into an esbuild plugin that is maintained in the Remix org.

[MichaelDeBoey]

@remorses I included @p-m-p's suggestions & test from #32, so I think this one's good to be merged in?

I'll try to talk to the Remix team about forking this package into the monorepo, but I don't they want to do so tbh.
The added test is proving that internal \0polyfill-node.* imports (which come from rollup-plugin-polyfill-node) are resolved properly, so I think we can merge this PR with confidence it won't break any other things.

[remorses]

Try using this plugin instead https://github.com/cyco130/esbuild-plugin-polyfill-node

This PR doesn't work

[MichaelDeBoey]

@remorses All tests are passing, so it should work now I guess?

Can you point me to what is still failing?
I'm happy to update this PR

[remorses]

Just use the plugin i linked above, the polyfill library used in this PR isn't much better than the one already used, the plugin i linked instead uses an actively maintained polyfill (jspm)