Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(dev): fix PostCSS tests in Node 14 #5988

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

markdalgleish
Copy link
Member

I noticed these tests failing in the release-test workflow since it runs the tests against Node v14 which doesn't have String.prototype.replaceAll, so this PR updates the code to use replace instead.

@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2023

⚠️ No Changeset found

Latest commit: 51ff142

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@markdalgleish markdalgleish merged commit 4f70391 into dev Apr 3, 2023
@markdalgleish markdalgleish deleted the markdalgleish/postcss-test-node14 branch April 3, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants