Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-dev): handle absolute bundled CSS URLs #5788

Merged
merged 4 commits into from
Mar 30, 2023

Conversation

markdalgleish
Copy link
Member

Closes: #5739

  • Docs
  • Tests

Testing Strategy:

A test case containing an absolute image URL has been added to the test suites for CSS Modules, Vanilla Extract and CSS side-effect imports.

@markdalgleish markdalgleish added bug Something isn't working package:dev labels Mar 14, 2023
@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2023

🦋 Changeset detected

Latest commit: 9b58195

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Patch
create-remix Patch
@remix-run/css-bundle Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish requested a review from pcattori March 30, 2023 00:21
@pcattori pcattori merged commit 9b5cb43 into dev Mar 30, 2023
@pcattori pcattori deleted the markdalgleish/absolute-css-urls branch March 30, 2023 13:50
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Mar 30, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-98dee11-20230331 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-27a2acd-20230401 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This issue has been fixed and will be released soon bug Something isn't working CLA Signed package:dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants