Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unstable_shouldReload references #5685

Merged
merged 4 commits into from
Mar 10, 2023

Conversation

brophdawg11
Copy link
Contributor

Removes references to the removed unstable_shouldReload, which was replaced by shouldRevalidate in 1.10.10

@changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2023

🦋 Changeset detected

Latest commit: c95edd7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/react Major
@remix-run/testing Major
create-remix Major
remix Major
@remix-run/architect Major
@remix-run/cloudflare Major
@remix-run/cloudflare-pages Major
@remix-run/cloudflare-workers Major
@remix-run/css-bundle Major
@remix-run/deno Major
@remix-run/dev Major
@remix-run/eslint-config Major
@remix-run/express Major
@remix-run/netlify Major
@remix-run/node Major
@remix-run/serve Major
@remix-run/server-runtime Major
@remix-run/vercel Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

docs/api/conventions.md Outdated Show resolved Hide resolved
Copy link
Member

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also delete these docs on main already?

@brophdawg11
Copy link
Contributor Author

brophdawg11 commented Mar 7, 2023

I thought about it but it's got the warning at the top already indicating it's not called past 1.10.0 so no real harm in leaving that there until v2 I don't think? https://remix.run/docs/en/1.14.0/route/should-reload.

It also doesn't seem like it's linked to from the sidebar anymore either in current docs?

@MichaelDeBoey MichaelDeBoey added the BREAKING CHANGE This change will require a major version bump label Mar 8, 2023
@brophdawg11 brophdawg11 removed the BREAKING CHANGE This change will require a major version bump label Mar 8, 2023
@brophdawg11 brophdawg11 merged commit ce52d03 into v2 Mar 10, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/remove-should-reload branch March 10, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants