Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server-runtime): fix SerializeFrom type inference #5516

Merged
merged 3 commits into from
Apr 11, 2023

Conversation

ronnylt
Copy link
Contributor

@ronnylt ronnylt commented Feb 19, 2023

Closes: #5211
Closes: #5938

  • Fixes serialization type inference when returned data has a data key. The fix brands TypedDeferredData to make it explicitly nominal instead of structural.
  • Added tests to cover most of the serialization cases.

Probably a different solution exists simplifying the current code and making use of @remix-run/router types.

@changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2023

🦋 Changeset detected

Latest commit: 0a882ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/react Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/cloudflare Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/node Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
create-remix Patch
@remix-run/css-bundle Patch
@remix-run/architect Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/vercel Patch
@remix-run/serve Patch
remix Patch
@remix-run/eslint-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori self-assigned this Feb 21, 2023
@mcansh mcansh force-pushed the fix-serialize-from branch from 1e96bf5 to 3cda0db Compare April 11, 2023 20:41
[skip ci]

Signed-off-by: Logan McAnsh <[email protected]>
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-9af8868-20230412 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants