Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added better detection for absolute urls in link component #5390

Merged
merged 3 commits into from
Feb 8, 2023

Conversation

brophdawg11
Copy link
Contributor

Wrapping up #5286 + adding changeset

@changeset-bot
Copy link

changeset-bot bot commented Feb 7, 2023

🦋 Changeset detected

Latest commit: a3c9294

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/react Patch
@remix-run/testing Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 merged commit c8515ab into release-next Feb 8, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/link-absolute-detection branch February 8, 2023 01:15
@kiliman
Copy link
Collaborator

kiliman commented Feb 8, 2023

BTW: another way to test local vs external URLs is via the URL object itself

let u = new URL('https://github.com/remix-run', 'http://localhost')
let isExternal = u.origin !== 'http://localhost'

@brophdawg11
Copy link
Contributor Author

That works for external URLs, and is what react-router does today - but this is specifically checking for absolute URL patterns.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

🤖 Hello there,

We just published version 1.13.0-pre.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.13.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants