Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: CSS side effect imports #4919

Merged
merged 115 commits into from
Jan 4, 2023
Merged

feat: CSS side effect imports #4919

merged 115 commits into from
Jan 4, 2023

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Dec 20, 2022 •
edited
Loading

Closes: #4817

  • Docs
  • Tests

Testing Strategy:

There is an integration test covering the build pipeline to ensure that all relevant styles end up on the page.

There's also a suite of unit tests to validate that CSS side effect imports are detected and annotated correctly for different usages of require/import.

I also trialled this in a playground using both uikit-test-using-css and React Spectrum that were referenced in the original issue: #2469

@markdalgleish
add initial CSS Modules integration
8b9d1b8
@markdalgleish
only write CSS bundle and source map to disk
4cc9f8e
@markdalgleish
Only emit CSS from the CSS bundle build
5a55f96
@markdalgleish
Merge branch 'dev' into markdalgleish/css-modules
72de4a3
@markdalgleish
bump css-bundle version
fc57bae
@markdalgleish
clean up CSS build output logic
5d96e1c
@markdalgleish
dispose CSS compiler in browser compiler
48aaaf3
@markdalgleish
remove emitCss option, clean up server output
9f40c89
@markdalgleish
make CSS Modules object type readonly
83eb997
@markdalgleish
add initial CSS Modules integration test
0dcd2dc
@markdalgleish
refactor local fork of CSS Modules plugin
33b09aa
@markdalgleish
bundle CSS to support composes property
1352cc5
@markdalgleish
put CSS Modules behind v2_cssBundle future flag
ec7e32a
@markdalgleish
Merge branch 'dev' into markdalgleish/css-modules
6381250
@markdalgleish
update css-bundle versions
b4e2168
@markdalgleish
rename v2_cssBundle flag to unstable_cssBundle
1599d3a
@markdalgleish
remove CSS Module entry point cache
88a0761
@markdalgleish
inline setup and buildCssModulesJs functions
f31cd7a
@markdalgleish
remove build context, clean up path resolution
600897a
@markdalgleish
use esbuild's resolver in lightningcss
657ef3e
@markdalgleish
refactor CSS Modules plugin
55653e7
@markdalgleish
upgrade lightningcss
08a6f66
@markdalgleish
use relative path for filename
d6d4d70
@markdalgleish
add workaround for CSS Modules hash clashes
ccf946f
@markdalgleish
simplify esbuild plugin, add PluginData type
e63338d
@markdalgleish
namespace compiled CSS suffix
ea3e3bd
@markdalgleish
use complete path for virtual CSS file name
be03658
@markdalgleish
split CSS Modules test cases, add more, clean up
e2c2d1a
@markdalgleish
Merge branch 'dev' into markdalgleish/css-modules
abdd5d3
@markdalgleish
bump css-bundle versions
1dc7da5
markdalgleish and others added 16 commits December 22, 2022 09:11
@markdalgleish @chaance
Update docs/guides/styling.md
6a30fb5 
Co-authored-by: Chance Strickland <[email protected]>
@markdalgleish @chaance
Update docs/guides/styling.md
cc96521 
Co-authored-by: Chance Strickland <[email protected]>
@markdalgleish @chaance
Update docs/guides/styling.md
5cb0efb 
Co-authored-by: Chance Strickland <[email protected]>
@markdalgleish @chaance
Update packages/remix-dev/compiler/compileBrowser.ts
cc5dc69 
Co-authored-by: Chance Strickland <[email protected]>
@markdalgleish @chaance
Update packages/remix-dev/compiler/compileBrowser.ts
3ebae45 
Co-authored-by: Chance Strickland <[email protected]>
@markdalgleish @chaance
Update docs/guides/styling.md
f0c7b82 
Co-authored-by: Chance Strickland <[email protected]>
@markdalgleish
dedupe CSS in dev
0da587d
@markdalgleish
remove explicit single CSS file warning from docs
c7357fa
@markdalgleish
remove redundant optional chaining
146ae5d
@markdalgleish
Merge branch 'dev' into markdalgleish/css-modules
ea9f2dc
@markdalgleish
Merge branch 'markdalgleish/css-modules' into markdalgleish/css-side-…
e230a36 
…effects
@markdalgleish
remove explicit single CSS file warning
983cd2b
@markdalgleish
update docs
26836e8
@markdalgleish
use consistent casing
9386ce9
@markdalgleish
rename "side effects" to "side-effect imports"
4e0023d
@markdalgleish
clean up regular expression
c8aa066
Base automatically changed from markdalgleish/css-modules to dev January 4, 2023 00:10
@markdalgleish markdalgleish marked this pull request as ready for review January 4, 2023 00:31
@markdalgleish markdalgleish merged commit 26f33ee into dev Jan 4, 2023
@markdalgleish markdalgleish deleted the markdalgleish/css-side-effects branch January 4, 2023 02:17
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jan 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-2c398e4-20230104 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

This was referenced Jan 13, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjackson mjackson mjackson approved these changes

Assignees
No one assigned
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed package:dev package:server-runtime package:testing renderer:react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markdalgleish @devongovett @mjackson @MichaelDeBoey