fix(remix-react): Remove nullish coalescing operator

[machour]

Closes: #

• Docs
• Tests

Testing Strategy:

I was testing my app with an iPhone 6, and found out the client side was totally broken.

We had a discussion with @sergiodxa a few days ago where we uncovered that we re-introduced a nullish coalescing operator ?? in #3697 that could be problematic for old browsers.

I can now confirm that it is indeed problematic. 🙃
This PR gets rid of it.

[changeset-bot]

🦋 Changeset detected

Latest commit: 08c8848

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages

Name	Type
@remix-run/react	Patch
create-remix	Patch
remix	Patch
@remix-run/architect	Patch
@remix-run/cloudflare	Patch
@remix-run/cloudflare-pages	Patch
@remix-run/cloudflare-workers	Patch
@remix-run/deno	Patch
@remix-run/dev	Patch
@remix-run/eslint-config	Patch
@remix-run/express	Patch
@remix-run/netlify	Patch
@remix-run/node	Patch
@remix-run/serve	Patch
@remix-run/server-runtime	Patch
@remix-run/vercel	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[MichaelDeBoey]

I don't think we should make this change like this tbh.
We're supporting Node v14+, so nullish coalescing should be possible to write without any problems.

In case of the older browser being broken, this is a matter of broken transpiling, most likely not taking these versions into account in browserslist

[machour]

Will happily update the PR if there's a better way to do it. Could you set me on the right track to fix the transpilling part?

[MichaelDeBoey]

@machour I think I once saw a discussion about supporting a browserslist config, because (if I correctly remember) we're currently only supporting the defaults provided by esbuild

[machour]

Gotcha. Leaving this as it is for the meantime. It was working, it's not anymore, so we may want to fix this first, then look at changing the way we do things.

[MichaelDeBoey]

If this only changed recently, this can be a bug introduced when @pcattori extracted browser+server compiler out of the massive compiler we had before. 🤔

Could be a totally different thing as well, I just know that we had some work done there 🤷‍♂️

[sergiodxa]

Until browserlist is supported I think this one line change it’s simpler and can help a lot of people support older browsers with ESM support

[chaance]

I'm going to merge this for now, but we'll prioritize a strategy for dealing with this to prevent regressions over the next week.

[pcattori]

If this only changed recently, this can be a bug introduced when @pcattori extracted browser+server compiler out of the massive compiler we had before. 🤔

The compiler code never makes it into the browser, so nullish coalescing is fine in compiler / server-only code.
In this case, its in useFormAction, which does make it into the browser.

I agree that we should allow Node v14 features like nullish coalescing in our codebase and just transpile them away for the browser build.

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-929d847-20221111 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!