CI test, do not merge #3584
Closed
CI test, do not merge #3584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getting a weird GH actions failure around the yarn cache on this PR: remix-run#2027 seeing if i can repro with another commit
1 task
jenseng
force-pushed
the
npm-install-cache-test
branch
2 times, most recently
from
da0d1f4 to
dab6435
Compare
jenseng
force-pushed
the
npm-install-cache-test
branch
from
dab6435 to
97c5949
Compare
|
✅ Confirmed, this looks like a bug in bahmutov/npm-install... on Windows, installs fail when using |
jenseng
added a commit
to jenseng/remix
that referenced
this pull request
Jun 28, 2022
v1.8.16 breaks cache miss installs on windows, which blocks any PRs/commits that change dependencies. Opened bahmutov/npm-install#146 to address the underlying issue, but in the meantime we can pin to the prior version to get things working again. Additional context: - Discord: https://discord.com/channels/770287896669978684/940264701785423992/991085961972707338 - Initial PR affected: remix-run#2027 - Repro/Debug PR: remix-run#3584
|
@MichaelDeBoey yup, issue filed here: bahmutov/npm-install#146 Also opened this Remix PR to pin the version if it's not a quick fix: #3587 |
|
going to debug this a little more to see if i can figure out the right fix to be applied upstream |
|
closing again, i have a simpler way to repro/debug :) |
jenseng
added a commit
to jenseng/remix
that referenced
this pull request
Jun 28, 2022
v1.8.16 breaks cache miss installs on windows, which blocks any PRs/commits that change dependencies. Opened bahmutov/npm-install#146 to address the underlying issue, but in the meantime we can pin to the prior version to get things working again. Additional context: - Discord: https://discord.com/channels/770287896669978684/940264701785423992/991085961972707338 - Initial PR affected: remix-run#2027 - Repro/Debug PR: remix-run#3584
jenseng
added a commit
to jenseng/remix
that referenced
this pull request
Jun 28, 2022
v1.8.16 breaks cache miss installs on windows, which blocks any PRs/commits that change dependencies. Opened bahmutov/npm-install#146 to address the underlying issue, but in the meantime we can pin to the prior version to get things working again. Additional context: - Discord: https://discord.com/channels/770287896669978684/940264701785423992/991085961972707338 - Initial PR affected: remix-run#2027 - Repro/Debug PR: remix-run#3584
jenseng
added a commit
to jenseng/remix
that referenced
this pull request
Jun 28, 2022
v1.8.16 breaks cache miss installs on windows, which blocks any PRs/commits that change dependencies. Opened bahmutov/npm-install#146 to address the underlying issue, but in the meantime we can pin to the prior version to get things working again. Additional context: - Discord: https://discord.com/channels/770287896669978684/940264701785423992/991085961972707338 - Initial PR affected: remix-run#2027 - Repro/Debug PR: remix-run#3584
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getting a weird GH actions failure around the yarn cache on this PR: #2027
seeing if i can repro with another commit