Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Deno import maps on release #3225

Merged
merged 11 commits into from
May 19, 2022

Conversation

MichaelDeBoey
Copy link
Member

No description provided.

jiahao-c and others added 2 commits May 17, 2022 13:35
…3216)

* Add `index.js.map` to `.gitignore`

In the Vercel template,  `/api/index.js.map` should also be ignored along with `/api/index.js`. Otherwise, that mapping file would be committed into version control, which is not desired.

* Sign CLA
@MichaelDeBoey MichaelDeBoey requested a review from pcattori May 18, 2022 19:05
scripts/utils.js Outdated Show resolved Hide resolved
@MichaelDeBoey MichaelDeBoey force-pushed the update-deno-import-maps branch from f78da4d to 866662d Compare May 18, 2022 19:27
@MichaelDeBoey MichaelDeBoey requested a review from pcattori May 18, 2022 19:28
@MichaelDeBoey MichaelDeBoey force-pushed the update-deno-import-maps branch from 866662d to 856d98f Compare May 18, 2022 19:30
@MichaelDeBoey MichaelDeBoey force-pushed the update-deno-import-maps branch from 856d98f to c15982f Compare May 18, 2022 19:45
@MichaelDeBoey MichaelDeBoey force-pushed the update-deno-import-maps branch from c15982f to 04548fc Compare May 18, 2022 20:37
@MichaelDeBoey MichaelDeBoey changed the base branch from dev to main May 18, 2022 20:38
@MichaelDeBoey MichaelDeBoey force-pushed the update-deno-import-maps branch from 04548fc to ff3c0b4 Compare May 18, 2022 20:53
scripts/utils.js Outdated Show resolved Hide resolved
scripts/utils.js Outdated Show resolved Hide resolved
@MichaelDeBoey MichaelDeBoey force-pushed the update-deno-import-maps branch from ff3c0b4 to 16df4d0 Compare May 19, 2022 00:41
@MichaelDeBoey MichaelDeBoey requested a review from pcattori May 19, 2022 00:42
@MichaelDeBoey MichaelDeBoey force-pushed the update-deno-import-maps branch from 16df4d0 to 6d4ee03 Compare May 19, 2022 08:19
@pcattori
Copy link
Contributor

pcattori commented May 19, 2022

@MichaelDeBoey this should target dev instead of main so that this code gets run for the next release.

@pcattori pcattori changed the base branch from main to dev May 19, 2022 15:12
@pcattori pcattori merged commit c28e179 into remix-run:dev May 19, 2022
pcattori added a commit that referenced this pull request May 19, 2022
pcattori added a commit that referenced this pull request May 19, 2022
@pcattori
Copy link
Contributor

pcattori commented May 19, 2022

@MichaelDeBoey sorry I switched to dev branch and the Github UI didn't update the commits right away and I merged a bunch of commits from main that we didn't want 😬 Could you make another PR targeting dev that cherry-picks your commit from this PR? cherry-picked your commit from this PR into #3255

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-000f37c-20220520 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@MichaelDeBoey MichaelDeBoey deleted the update-deno-import-maps branch May 20, 2022 09:54
christophertrudel pushed a commit to christophertrudel/remix that referenced this pull request May 21, 2022
* fix(templates/vercel): add `index.js.map` to `.gitignore` (remix-run#3216)

* Add `index.js.map` to `.gitignore`

In the Vercel template,  `/api/index.js.map` should also be ignored along with `/api/index.js`. Otherwise, that mapping file would be committed into version control, which is not desired.

* Sign CLA

* fix(scripts): Prevent publishing without a tag (remix-run#3223)

* move decisions

* docs: add `decisions/index.md` and frontmatter (remix-run#3226)

Co-authored-by: Pedro Cattori <[email protected]>
(cherry picked from commit e809206)

* docs(server-runtime): update link for deno server runtime package (remix-run#3228)

since it's now a proper package

* chore(templates): bring `deno` template in line with other templates (remix-run#3221)

* docs: fix links to decision docs (remix-run#3231)

* chore: update Deno import maps on release

Co-authored-by: Jiahao <[email protected]>
Co-authored-by: Chance Strickland <[email protected]>
Co-authored-by: Ryan Florence <[email protected]>
Co-authored-by: Logan McAnsh <[email protected]>
Co-authored-by: Pedro Cattori <[email protected]>
christophertrudel pushed a commit to christophertrudel/remix that referenced this pull request May 21, 2022
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-d19d888-20220522 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

justjavac pushed a commit to justjavac/remix that referenced this pull request Jun 11, 2022
* fix(templates/vercel): add `index.js.map` to `.gitignore` (remix-run#3216)

* Add `index.js.map` to `.gitignore`

In the Vercel template,  `/api/index.js.map` should also be ignored along with `/api/index.js`. Otherwise, that mapping file would be committed into version control, which is not desired.

* Sign CLA

* fix(scripts): Prevent publishing without a tag (remix-run#3223)

* move decisions

* docs: add `decisions/index.md` and frontmatter (remix-run#3226)

Co-authored-by: Pedro Cattori <[email protected]>
(cherry picked from commit e809206)

* docs(server-runtime): update link for deno server runtime package (remix-run#3228)

since it's now a proper package

* chore(templates): bring `deno` template in line with other templates (remix-run#3221)

* docs: fix links to decision docs (remix-run#3231)

* chore: update Deno import maps on release

Co-authored-by: Jiahao <[email protected]>
Co-authored-by: Chance Strickland <[email protected]>
Co-authored-by: Ryan Florence <[email protected]>
Co-authored-by: Logan McAnsh <[email protected]>
Co-authored-by: Pedro Cattori <[email protected]>
justjavac pushed a commit to justjavac/remix that referenced this pull request Jun 11, 2022
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v1.6.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants