Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esm-only package alerts on esm server build #7171

Closed
1 task done
mikeybinns opened this issue Aug 15, 2023 · 2 comments
Closed
1 task done

esm-only package alerts on esm server build #7171

mikeybinns opened this issue Aug 15, 2023 · 2 comments
Labels
bug:unverified

Comments

@mikeybinns
Copy link
Contributor

What version of Remix are you using?

19.2

Are all your remix dependencies & dev-dependencies using the same version?

  • Yes

Steps to Reproduce

Set serverModuleFormat: "esm", in remix.config.js
Install ESM only package e.g. getaddress-api
Run npm run dev

Expected Behavior

Remix flags commonjs only packages to be bundled by serverDependenciesToBundle.

Actual Behavior

Remix flags esm-only only packages to be bundled by serverDependenciesToBundle.
@mikeybinns
Copy link
Contributor Author

Note: the web build works fine without bundling these deps, so at the very least, the warning is inaccurate.

Screenshot of warning:
image

@pcattori
Copy link
Contributor

Fixed by #6916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:unverified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pcattori @mikeybinns