Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.16.0 / 1.16.1 / 1.17.0 : No matching export in "node_modules/esbuild-plugin-polyfill-node/polyfills/empty.js" for import "writeFile" #6557

Closed
1 task done
raskyer opened this issue Jun 7, 2023 · 5 comments · Fixed by #6562

Comments

@raskyer
Copy link

raskyer commented Jun 7, 2023

What version of Remix are you using?

1.17.0

Are all your remix dependencies & dev-dependencies using the same version?

  • Yes

Steps to Reproduce

  • Install Remix 1.17.0
  • Install ical-generator
  • Run npm run dev

(On the history dev server but I suspect the same effect on new dev server)

Expected Behavior

Works as in 1.15.0

Actual Behavior

✘ [ERROR] No matching export in "node_modules/esbuild-plugin-polyfill-node/polyfills/empty.js" for import "writeFile"

node_modules/ical-generator/dist/index.js:60:13:
  60 │ `,t}};import{writeFile as H,writeFileSync as W,promises as q}from"...
     ╵              ~~~~~~~~~

✘ [ERROR] No matching export in "node_modules/esbuild-plugin-polyfill-node/polyfills/empty.js" for import "writeFileSync"

node_modules/ical-generator/dist/index.js:60:28:
  60 │ `,t}};import{writeFile as H,writeFileSync as W,promises as q}from"...
     ╵                             ~~~~~~~~~~~~~

✘ [ERROR] No matching export in "node_modules/esbuild-plugin-polyfill-node/polyfills/empty.js" for import "promises"

node_modules/ical-generator/dist/index.js:60:47:
  60 │ ...ile as H,writeFileSync as W,promises as q}from"fs";var F=(g=>(g...
@brophdawg11
Copy link
Contributor

This might be handled by #6547

@MichaelDeBoey
Copy link
Member

We just published version 1.17.1-pre.0 which includes #6562 (a possible fix). If you'd like to take it for a test run please try it out and let us know what you think!

@huyb1991
Copy link
Contributor

Tested 1.17.1-pre.0, works for me following syntax:

import { promises } from 'fs';

return promises.writeFile(FILE_PATH, content);

@MichaelDeBoey
Copy link
Member

Closed by #6562

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.17.1 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants