Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warnOnceIfEsmOnlyPackage erroneously warned for marked #4324

Closed
jamesarosen opened this issue Oct 4, 2022 · 3 comments
Closed

warnOnceIfEsmOnlyPackage erroneously warned for marked #4324

jamesarosen opened this issue Oct 4, 2022 · 3 comments

Comments

@jamesarosen
Copy link

jamesarosen commented Oct 4, 2022

What version of Remix are you using?

1.6.5

Steps to Reproduce

Add marked to dependencies, run remix run.

Expected Behavior

No warning message, since marked publishes CJS and ESM in the same package:

"main": "./lib/marked.cjs",
"module": "./lib/marked.esm.js",
"browser": "./lib/marked.umd.js",

markedjs/marked#2281 has some relevant history.

Actual Behavior

remix dev emits

marked is possibly an ESM only package and should be bundled with "serverDependenciesToBundle in remix.config.js.

@machour
Copy link
Collaborator

machour commented Oct 5, 2022

@jamesarosen could you try with the latest Remix version?

@machour machour added the needs-response We need a response from the original author about this issue/PR label Oct 5, 2022
@jamesarosen
Copy link
Author

Good call. I tested on 1.7.2 and the issue remains:

$ npm list @remix-run/dev
co2-frontend@ /Users/jamesrosen/Code/fe
└── @remix-run/[email protected]

$ npm run dev

> dev
> remix dev

Loading environment variables from .env
Watching Remix app in test mode...
marked is possibly an ESM only package and should be bundled with "serverDependenciesToBundle in remix.config.js.

@machour machour removed the needs-response We need a response from the original author about this issue/PR label Oct 6, 2022
@brophdawg11 brophdawg11 added this to v2 Aug 3, 2023
@brophdawg11 brophdawg11 moved this to Backlog in v2 Aug 3, 2023
@pcattori
Copy link
Contributor

pcattori commented Aug 4, 2023

Fixed by #6916

@pcattori pcattori closed this as completed Aug 4, 2023
@pcattori pcattori moved this from Backlog to Closed in v2 Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Closed
Development

No branches or pull requests

4 participants