Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Migrate from xdm to mdx-js v2 #1802

Closed
benseitz opened this issue Feb 4, 2022 · 5 comments
Closed

[Feature]: Migrate from xdm to mdx-js v2 #1802

benseitz opened this issue Feb 4, 2022 · 5 comments

Comments

@benseitz
Copy link

benseitz commented Feb 4, 2022

What is the new or updated feature that you are suggesting?

A few days ago MDX 2 got released!

I propose to migrate from xdm to mdx-js v2.

Why should this feature be included?

As far as I understand all features from xdm are now part of mdx-js v2.
Also, it seems like xdm could not be supported sometime in the future.
(see: wooorm/xdm/issues/94 and kentcdodds/mdx-bundler/issues/137)

For me, it would make sense to migrate to the official mdx-js for these reasons.

Is this something you would want as well?
Or is someone already working on this? Would you be interested in a PR?

@benseitz benseitz changed the title [Feature]: Migrate form xdm to mdx-js v2 [Feature]: Migrate from xdm to mdx-js v2 Feb 14, 2022
@axe312ger
Copy link

As far as I know, MDX2 got a lot of learnings & code from xdm. That should mean, the migration effort is not too high.

@mayank99
Copy link

xdm now explicitly recommends using mdx 2 as well.

@chaance
Copy link
Collaborator

chaance commented Apr 19, 2022

Happy to take a PR to address this. Going to close the issue as it's not a top priority in the meantime.

@jacobwgillespie
Copy link
Contributor

Hey, I have opened a PR for this here: #4054. As a bonus, removing xdm will remove deasync, which is a native dependency that requires compilation (which can break).

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-b1149bb-20230810 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants