Make getLoadContext async for all adapters

[arielvieira]

Right now the getLoadContext it's already async for @remix-run/deno

remix/packages/remix-deno/server.ts

Line 29 in 935464d

const loadContext = await getLoadContext?.(request);

But is not async for the other adapters, for now I'm patching the cloudflare adapter so I can use it as async, but would be really awesome to have it async by default for every other providers beside deno

getLoadContext code from other adapters

@remix-run/architect

remix/packages/remix-architect/server.ts

Line 53 in 935464d

let loadContext = getLoadContext?.(event);

@remix-run/cloudflare-pages

remix/packages/remix-cloudflare-pages/worker.ts

Line 31 in 935464d

let loadContext = getLoadContext?.(context);

@remix-run/cloudflare-workers

remix/packages/remix-cloudflare-workers/worker.ts

Line 40 in 935464d

let loadContext = getLoadContext?.(event);

@remix-run/express

remix/packages/remix-express/server.ts

Line 56 in 935464d

let loadContext = getLoadContext?.(req, res);

@remix-run/netlify

remix/packages/remix-netlify/server.ts

Line 50 in 935464d

let loadContext = getLoadContext?.(event, context);

@remix-run/vercel

remix/packages/remix-vercel/server.ts

Line 50 in 935464d

let loadContext = getLoadContext?.(req, res);

And even in hydrogen it is async as well
https://github.com/Shopify/hydrogen/blob/2023-04/packages/remix-oxygen/src/server.ts#L21

[MichaelDeBoey]

Created a PR to support this out of the box: #6170

[kiliman]

Nice. Just note that Express handlers are not async by default, so you'll need something like express-async-handler or @awaitjs/express

https://zellwk.com/blog/async-await-express/

import asyncHandler from 'express-async-handler'

app.all('*', asyncHandler(handleRequest))

async function handleRequest(
  req: express.Request,
  res: express.Response,
  next: express.NextFunction,
) {
  if (MODE === 'development') {
    purgeRequireCache()
  }
  let build = require(BUILD_DIR)
  let loadContext = await getLoadContext(req, res)
  
  return createRequestHandler({
    build,
    mode: MODE,
    getLoadContext: loadContext
  })(req, res, next)
}

[MichaelDeBoey]

requestHandler was already async typed though

remix/packages/remix-express/server.ts

Lines 29 to 33 in 73e7517

	export type RequestHandler = (
	req: express.Request,
	res: express.Response,
	next: express.NextFunction
	) => Promise<void>;

[kiliman]

Ok, perhaps this was what I was referencing

remix/packages/remix-express/server.ts

Lines 64 to 68 in 73e7517

	} catch (error: unknown) {
	// Express doesn't support async functions, so we have to pass along the
	// error manually using next().
	next(error);
	}

[arielvieira]

That was fast @MichaelDeBoey, thanks! 😄

[MichaelDeBoey]

@arielvieira I thought all of them where already async tbh 🤔🙈