Memoize result from useRouteMatch() when a path is passed #7822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #7019
* explain same component in multiple routes wanted to clarify the behavior seen here: https://codesandbox.io/s/sleepy-hopper-bgntr * Update packages/react-router/docs/api/Route.md Co-Authored-By: Tim Dorr <[email protected]>
As suggested in [CRA Readme](https://github.com/facebook/create-react-app#quick-overview) and to avoid [warnings related](https://stackoverflow.com/questions/59188624/template-not-provided-using-create-react-app)
* Add documentation for component prop Documented the existence of the `component` prop and gave an example illustrating how to use it * Update Link.md
* Fixed Link component prop type check * Update packages/react-router-native/Link.js Co-authored-by: Tim Dorr <[email protected]>
* Clearly describe API of callback in code * fix syntax error
Update to latest version, as it doesn't depend anymore on the `gud` package, a package that has a problematic license file (missing copyright). The API seems to be the same, so there shouldn't be any issues with this update.
the test has passed the rollup packaging mechanism!
Co-authored-by: Tim Dorr <[email protected]>
Co-authored-by: Zavrazhnev Konstantin <[email protected]>
Since the project doesn't have much activity right now, issues and PRs are getting closed without further investigation. Until either Ryan or Michael can devote some more time to React Router (understand they are _very_ busy at the moment and fighting to survive the pandemic economy), let's just turn this thing off for now.
Closes #7789
"navigates home when you click the logo" fails because of minor issues * the path to the route with the link was wrong * the id for the link was wrong * the text on the target page was wrong * providing an argument to the anonymous function makes the timeout waiting for completion callback
timdorr
reviewed
Apr 19, 2021
timdorr
reviewed
Apr 19, 2021
|
@timdorr I've incorporated the feedback, can you take another look? |
jonkoops
commented
Apr 20, 2021
| } | ||
|
|
||
| const path = "/home"; | ||
| const renderer = create( |
There was a problem hiding this comment.
Perhaps I should be wrapping this in a renderStrict call as well. Can't really use it directly since renderStrict calls ReactDOM, but I could export the StrictMode wrapper used there.
|
@timdorr any chance you can take a look into this to see if it can be merged? |
|
@mjackson is better suited for this than me right now. |
|
@mjackson Would you prefer that I direct this change into v6? I can see the same behavior is still present there for Also will v6 still have the |
|
Closing this PR as the conflicts with the new version are just too great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds more test cases, closes #7059