Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown loader #7543

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Fix markdown loader #7543

merged 1 commit into from
Aug 4, 2020

Conversation

emision
Copy link
Contributor

@emision emision commented Aug 4, 2020

After fix in f20b6fe

when start website local dev exist a lot of errors

ERROR in ../packages/react-router-dom/docs/guides/quick-start.md Module build failed (from ./webpack/markdown-loader.js): TypeError: Cannot read property 'basename' of null at Object.module.exports (/mnt/c/code/react-router/website/webpack/markdown-loader.js:153:28) @ ./modules/docs/Web.js (./node_modules/babel-loader/lib!./modules/docs/Web.js) 77:11-83 @ ./node_modules/bundle-loader?lazy!./modules/docs/Web.js @ ./modules/components/Environment.js @ ./modules/components/App.js @ ./modules/index.js

@timdorr
Copy link
Member

timdorr commented Aug 4, 2020

Thanks!

@timdorr timdorr merged commit cbcf6f2 into remix-run:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants